On 16/02/09 18:17, Luke Kanies wrote: > On Feb 14, 2009, at 10:45 AM, Brice Figureau wrote: > >> Hi, >> >> I'm proud to announce I've finished my work on the Application >> Controller >> refactoring. It is based on (a rather) current master (so it is on >> top of #1405). >> >> I tested all applications before the rebasing so I'm pretty >> confident of >> my original work. I didn't retest much after the rebase (except >> running >> the unit tests, of course). >> >> Please review, comment and merge ASAP (if it meets the various >> requirements), >> as the final rebase was really painful even though there wasn't too >> much >> modifications to the bin/. >> >> Once it will be merged, I'll finish the work, that is remove >> duplicated >> code in the various application setup, or the --debug and --verbose >> options handling (which for the moment is different for each >> application). >> >> Also, testing by someone else than me would be great, as there are >> tons of >> option combination and I couldn't test everything. >> >> The code is right now in my github repository, branch feature/ >> appcontroller: >> http://github.com/masterzen/puppet/tree/feature/appcontroller > > Oh, one more thing -- this isn't required or anything, but it would be > simpler to read this commit series if you ran it through 'rebase -i > master, and squashed paired commits. > > E.g., the application + option parser commits could be squashed into a > single commit, and each pair of commits per executable -- the first > porting to the application controller, the second porting to the new > option system -- could probably easily be squashed into a single commit. > > This way there's no need to review code that's just being removed > anyway. I just tried this, and it worked with no merging necessary, > and reduced the patch list to 12 patches from 22.
I know, this is already a rebase -i of more than 50 commits (you wouldn't have read them, trust me :-)). I wanted to present something that expressed my intent by offerring several refinements (there are only two at that stage, but I initially wanted to have a 3rd pass to eliminate common code) instead of a massive block of code thrown out of nowhere. Note that the 11 later commits are rather short. Do you want me to perform and publish the squash? -- Brice Figureau Days of Wonder http://www.daysofwonder.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
