This is quite a big change that if approved should be highlighted strongly in the release notes.
We currently do a lot of string "true" "false" facts, and case on the string values in puppet manifests. I'm not saying I'm against the change, I think it's reasonably logical, but it could break a lot of existing configurations. On Tue, Feb 24, 2009 at 10:05 AM, Peter Meier <peter.me...@immerda.ch> wrote: > > change the behavior of the parser so that string variables containing > "false" are interpreted as false in decision statements etc. > --- > lib/puppet/parser/scope.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/puppet/parser/scope.rb b/lib/puppet/parser/scope.rb > index 4acdf41..914735d 100644 > --- a/lib/puppet/parser/scope.rb > +++ b/lib/puppet/parser/scope.rb > @@ -36,7 +36,7 @@ class Puppet::Parser::Scope > # Is the value true? This allows us to control the definition of truth > # in one place. > def self.true?(value) > - if value == false or value == "" or value == :undef > + if value == false or value == "" or value == "false" value == :undef > return false > else > return true > -- > 1.6.0.6 > > > > > -- Nigel Kersten Systems Administrator Tech Lead - MacOps --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
