2009/5/6 Luke Kanies <[email protected]>: >
> I talked with Sam about it a bit yesterday, and basically, he's > duplicated the structure of the AIX code, which is a reasonable first > try. I'd recommended refactoring to push all of the logic into the > resolution, but then you'd need to cache data (to avoid running the > manifest command for every fact value) and Facter has no simple > caching system yet. > > So, I figured that while this isn't great, it does at least add a bit > more hpux support and isn't any worse than anything else we have. Sure, we can commit this and work on the general improvments for 2.0/1.6 +1 > We really need to add the ability to uniquely identify and retrieve > resolutions, so we can test those individual resolutions. Well if we have load by name it's doable - see the patches for operatingsystem I sent which have some tests around that. >> For some examples see eg spec/unit/util/ip.rb > > This would require abstraction into a library, and the ip library is > already ahving performance problems because there's no caching - the > ip data is collected many, many times. One client says Facter can > take up to 25% of run time because of all the ip stuff. Yeah I'll look at that and know it needs doing Paul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
