(Continued) Since the bundled json approach was getting complicated I went back and implemented the absolute simplest of the remaining approaches--it's effectively one line of code, no structural change (it makes use of an existing hook to simply remove the extra "\n"s with a gsub), and it lowers the odds of the bug occurring in the real world by several orders of magnitude, back to what is was in 0.24.x
Neither of them are ready for inclusion, but both are fair game for discussion. Sent via BlackBerry from T-Mobile -----Original Message----- From: [email protected] Date: Tue, 29 Sep 2009 23:28:01 To: <[email protected]> Subject: [Puppet-dev] Re: [PATCH/puppet 2/2] Interim fix for #2615 (templatespicking up extra "/n"s) I'll try to clarify the murk (pardon any thumb-typing typos). 0.25 uses Symbols as hash keys. This doesn't work for sites with mixed configurations (ruby 1.8.1 and something newer) unless they use son because: - mixed version marshal segments - ya ml on 1.8.1 can't handle the newer way of serialised symbols We tried to fix this for 0.25 by monkey patching yaml but were constrained in our options because it has to work on all supported versions. The patch revealed an existing bug by making it several orders of magnitude more likely. The bug ocurrs when a string ending in multiple \n chars occurs directly before a place where yaml inserts a line break to force indentation. We made such place much more common. There are, if you work it out, something like 17 permutations in the solution space. Some, like dropping support for 1.8.1 are not pracitable, and others, like patching 1.8.1's yaml to recognise the newer symbol encoding we haven't found a way to do. Our favorite is bundling jason, but there are costs/consequences to this that arguably exceed the scope of a point release (more than a bug fix). (Rails / compiled code issues.) Plane taking off more later. --M Sent via BlackBerry from T-Mobile -----Original Message----- From: James Turnbull <[email protected]> Date: Tue, 29 Sep 2009 14:38:29 To: <[email protected]> Subject: [Puppet-dev] Re: [PATCH/puppet 2/2] Interim fix for #2615 (templates picking up extra "/n"s) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Luke Kanies wrote: > I'm a bit lost as to what we're actually doing - I seem to be losing > the thread between recommended and potential solutions. > > Care to enlighten me on the overall state here, again? +1 - me too. Regards James Turnbull - -- Author of: * Pro Linux Systems Administration (http://tinyurl.com/linuxadmin) * Pulling Strings with Puppet (http://tinyurl.com/pupbook) * Pro Nagios 2.0 (http://tinyurl.com/pronagios) * Hardening Linux (http://tinyurl.com/hardeninglinux) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEVAwUBSsJ+VSFa/lDkFHAyAQKdVggAkhLud7/1rqBPCxB/cK4NHAnoBGWlYhEi 6klqxFTsYSjxQcNVHGdd9P5zUd7VXVV9Pu0fptpqzVnMhJsl0DUL8nUhlk9N0fZE cxDjF2//yt0FvdkXvl8dG7XZPf+HDTyUh/l3OQa9Su6s88FxEg04dIKCc1thv4tg /0DFYt3+jK0YnpOaDS9UKr6QtjvpMr/bVg/46Ky2HXbnmp1XmW3gN/OcHXl+SO2C KSzZbQrf30gX7RpTGyKyC8xm5Nejgb6CtRVIBdD6Aq/K0PVgyTkASU7DAhX7Boz5 B61BQ6OtZ+GN+m0/JI3sjR8bTJCDWmokdxSNCVMDllMVxs78Mgj89Q== =sIHm -----END PGP SIGNATURE----- --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
