On Oct 15, 2009, at 9:50 AM, Robin Bowes wrote: > > On 14/10/09 22:51, Luke Kanies wrote: >> >> I personally disagree that these idioms qualify as code smell, >> since I >> use them to avoid a warning (ruby -w is essentially entirely useless >> if you don't tend to use this idiom). >> >> I appear to be "unanimously" overridden, though, so I'll bow out of >> that part of the discussion. > > I don't really know ruby, but if it's anything like perl (I have a > perl > background) then warnings are very useful. > > It's accepted PBP [1] to run all code with warnings enabled and to > write > your code so that it doesn't generate warnings. > > Perhaps ruby is different? If it is, then I'm not qualified to speak > about this. If not, I agree with Luke.
This is pretty much the argument that I lost with Rein and Markus yesterday. I'm sure they'll happily correct me, but the reasoning, I think, was: 1) No one ever does that in the Ruby community (e.g., run rails with warnings enabled, I dare you) 2) Everyone at PuppetCamp absolutely hates this idiom I'd still prefer that the Puppet code generate no, or at least very few, warnings. -- A gentleman is a man who can play the accordion but doesn't. --Unknown --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
