On Nov 7, 2009, at 10:00 AM, Brice Figureau wrote: > > On 07/11/09 16:35, Markus Roberts wrote: >>>>> that - I see now that the wiki ( >> >>>>> http://reductivelabs.com/trac/puppet/wiki/UsingStoredConfiguration >>>>> ) says it requires at least 2.2.2 . If that's true, then let's >>>>> withdraw this patch and ask people to upgrade ActiveRecord. >>>> >>>> Don't forget to add a note to that effect to the ticket and change >>>> it from "Investigating" to "Rejected." >>> >>> Is the wiki really authoritative here? I thought that 2.1 was still >>> supported based on Luke's change in 1a5c5b3 (Fixing #2508 - removing >>> mention of ActiveRecord 2.3), which changed: >>> >>> - raise "StoreConfigs not supported without >>> ActiveRecord >>> 2.3" unless Puppet.features.rails? >>> + raise "StoreConfigs not supported without >>> ActiveRecord >>> 2.1 or higher" unless Puppet.features.rails? >>> >>> Please forgive me if I'm misunderstanding. >>> >> >> No worries. I was under the same impression. And note that the >> comment >> that kicked off this sub-thread is qualified "If that is true, >> then..." >> >> So perhaps we should address that head on. Is Rails 2.1 supported >> with >> 0.25.x? > > Right now, no (which is the bug in question that this whole thread is > trying to address). > > Should it be supported, I'd say yes, since this is a regression from > 0.24.8 and it's not in the release notes. > > Of course the workaround is to upgrade rails to 2.2 or 2.3, it's just > that it generates support request, and/or request rails >= 2.2 in the > rails feature.
I thought we were compatible, but I guess having removed this line (which got rid of a warning with newer versions of Rails) we've hurt performance on older versions. I'm comfortable adding it back in, but it should be done in a way that's version-sensitive. And ftr, the reason I added 2.1 support back in was 1) it seemed to actually work for everyone and 2) it's quite difficult to use Puppet to upgrade Rails without having multiple versions supported at once. -- You wake me up early in the morning to tell me I am right? Please wait until I am wrong. -- Johann von Neumann --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
