I responded to the pull request with this:
This is a duplicate of #2346
I don't think this is sufficient as open-uri opens a url, you've
changed the type to the second argument to Kernel#open is
open(path [, mode [, perm]] ) => io or nil
OpenURI::OpenRead#open takes optional 3 arguments as:
OpenURI::OpenRead#open([mode [, perm]] [, options]) [{|io| … }]
mode’,perm’ is same as Kernel#open.
A discussion on the bugs in the ec2 fact and a fix that leads to a 2
second timeout everywhere there was discussed here:
http://groups.google.com/group/puppet-dev/browse_thread/thread/ab1570b7fc9c49fd/c91a1b1c19cfebc0
Probably we need to be smarter is to use only do ec2 checking if on a
supported virt platform, plus the fixes for Timeout error handling and
open-uri in my branch
http://github.com/pnasrat/facter/tree/tickets/master/2346
Paul
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
