On 09/02/10 19:32, Markus Roberts wrote:
> I am confused about a number of things with this patch; I'll pick out
> one that seems the easiest to explain in the hopes that the answer
> will allign my thinking:
> 
> I don't see how the following could work:
> 
>     def find(request)
> -        return nil unless result =
> deserialize(network(request).get(indirection2uri(request), headers))
> +        return nil unless result =
> network(request).request_get(indirection2uri(request), headers) do
> |response|
> +            return deserialize(response)
> +        end
>         result.name = request.key
>         result
>     end

I rewrote this part as I sent earlier and indeed this still works,
except it wasn't doing the result.name= stuff.
It allowed me to discover that this result.name= was failing hard when
trying to fetch file metadata (those have no "name"). This is also fixed
in the new patch revision.

-- 
Brice Figureau
My Blog: http://www.masterzen.fr/

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to