This edition contains more code and fails fewer tests then the previous
ones, thought it still fails over two hundred at the head. Today I'm going
to be working on fixing test failures (by fixing the code or the test, as
needed) and Jesse's finishing up the REST conversions.
Building testing branch succeeded:
*
7762 examples, 15 failures, 43 pending
1 more in integration/bin/puppetmasterd.rb (1 total)
2 more in integration/util/settings.rb (2 total)
1 more in unit/indirector/ssl_file.rb (1 total)
2 more in unit/node/environment.rb (2 total)
3 more in unit/parser/scope.rb (3 total)
2 more in unit/provider/package/pkg.rb (2 total)
3 more in unit/ssl/host.rb (3 total)
1 more in unit/type/augeas.rb (1 total)
markus:refactor/master/scope-v-compiler (Moving things out of compiler to
fix bugs) succeeded:
* 7d7d1de Move scope parenting & class_scope from Compiler to Scope
7763 examples, 12 failures, 43 pending
3 fewer in unit/parser/scope.rb (0 total)
ethanrowe:tickets/master/2239 (TERM signal) succeeded:
* bc0cd89 Fix 2239 (step one): introduce global settings represeting
application run state with methods for setting the state and
appropriately-named predicates for querying state, all in the
Puppet::Application class itself. To be used by Puppet::Daemon and
Puppet::Agent and Puppet::Transaction for better response to TERM, INT, HUP.
* 8193ea0 Fix 2239 (step two): introduce
Puppet::Application.controlled_run method to provide simple
status-restricted execution of a passed in block; this can replace the
process status checks and properly handle delayed restart behavior for
Puppet::Agent.
* 200da73 Fix 2239 (step three): Refactored Puppet::Agent to base
starting/restarting behaviors and predicates on new run-status interface of
Puppet::Application.
* 3ef61ad Fix 2239 (step four): Refactored Puppet::Daemon's stop/restart
methods to set status flags appropriately in Puppet::Application, and
removed call to now-deprecated @agent.configure_delayed_restart. This
should get the restart and stop behavior for daemons and their agents
working nicely with the new global process status interface of
Puppet::Application.
* 5918aaf Fix 2239 (step five): introduce new
Puppet::Transaction#stop_processing? flag and associated check thereof
within the resource evaluation code. This should allow for the transaction
to bail out of its processing if it finds that a stop has been requested,
based on the state of Puppet::Application.stop_requested?.
7785 examples, 14 failures, 43 pending
2 more in unit/transaction.rb (2 total)
jesse:ticket/master/3148 (Bug fixes) succeeded:
* b3463c5 Fixing #3148 Settings#without_noop when run with no noop
setting
7786 examples, 14 failures, 43 pending
2 fewer in integration/util/settings.rb (0 total)
2 more in unit/type/schedule.rb (2 total)
andrew:ticket/0.25.x/2805 (AIX support) succeeded:
* b0fdab4 Add AIX package management support (installp&nim)
7800 examples, 16 failures, 43 pending
2 more in unit/provider/package/nim.rb (2 total)
luke:tickets/master/2759 (Events) succeeded:
* 360580f Moving log destination code into separate files
* 27eba9d removing never-used code
* 0cda491 Switching transactions to callback-based events
* 56a45b5 Moving Parameter utility classes into separate files
* 4639bee Moving Ensure property into separate file
* fda1938 Random code cleanup
* f627597 Adding "type" instance method to enhance Demeterness
* 9202dba Cleaning up Event creation
* 15144b0 Reorganizing Property class to match current style
* fd4b20a Moving event creation to the resource
* 12833c8 Changing SimpleGraph.matching_edges to expect one event
* c5105d2 Extracting event management into a separate class
* ab7b34a Adding tests for the 'report' log destination
* fda5078 Removing unused code and adding a couple of tests
* 44f26f0 Removing a redundant method in Report
* 353a529 Adding Transaction events to Transaction reports
* 30d6c4d removing extraneous comment
* f05c18b Fixing file content logs
* db038ae Failing in app/puppet if facts are not found
* aaba09b Correcting comments and making report timestamp internal
* e22365e Adding tests for "Logging" module
* 0bc5050 Using Logging module in main Puppet module
* 2bd6fd4 Refactoring the RAL interface to logging
* a210747 Cleaning up the Log initialization code.
* 61cabd3 Refactoring the Change/Event/Property interface
* 97ed297 Solidifying the RAL/Event integration.
* c5f22e7 Removing last event collection transaction code
* 604300d Fixing File type indentation
* afff949 Adding first version of Resource::Status class
* 935ce9f Adding Transaction::ResourceHarness class
* 52957ed Renaming some methods in Transaction::Change
* 2075a7a Fixing some compatibility and old tests
* 6a66fd3 Fixing log message when changes fail
* 0ac6e93 Changing Transaction to use the new ResourceHarness
* 4334ef9 ResourceHarness now doesn't check params with no 'should'
* 0366506 Fixing #2759 - reports now have complete change info
* 3fa51bf Cleaning up the report tests a bit
* 94e2030 Removing mention of @changes in Transaction
* f9ff663 Moving Metric management to the reports
8033 examples, 51 failures, 44 pending
1 more in integration/configurer.rb (1 total)
1 more in integration/indirector/report/rest.rb (1 total)
1 more in integration/type/file.rb (1 total)
2 more in unit/application/puppetd.rb (2 total)
3 more in unit/transaction.rb (5 total)
4 more in unit/type/file/selinux.rb (4 total)
22 more in unit/type/package.rb (22 total)
1 more in unit/type/user.rb (1 total)
markus:ticket/master/3225 (Fix for minor bug in luke:tickets/master/2759)
succeeded:
* d2541eb Fix for transcription error in luke:tickets/master/2759
8033 examples, 32 failures, 44 pending
18 fewer in unit/type/package.rb (4 total)
1 fewer in unit/type/user.rb (0 total)
luke:tickets/master/3015 (Per Environment known resource types) succeeded:
* 6ffa10f Adding []/[]= support to Parser::Resource
* 40276f9 Fixing test structure
* f5e7084 Adding support for parsing ruby files
* 5db8b97 Removing old, never-used DSL code
* 784825d Storing per-environment LoadedCode instances
* bf1d92e Renaming LoadedCode to ResourceTypeCollection
* b1c8a23 Adding 'known_resource_types' to Environment
* e969330 Parser now uses Environment resource type collection
* 42a0ba6 Moving Rails initialization to Compiler terminus
* 9cfe13b Adding helper module for finding known resource types
* 7d6ae93 Always warning if autoloading a file fails
* 1b1a8d3 Using the RTC helper to find the known resource types
* 422abd7 Fixing callers to Parser to only pass environment
* aa1d169 All non-transient parser references are gone
* ad5e9a7 Removing Interpreter class
* 93b19d5 Renaming Parser::ResourceType to Resource::Type
* e1fc710 Resolving conflicts between luke:tickets/master/3015 and ???
8057 examples, 67 failures, 44 pending
3 more in integration/indirector/catalog/compiler.rb (3 total)
2 more in integration/node.rb (2 total)
1 more in integration/node/facts.rb (1 total)
1 more in integration/parser/functions/include.rb (1 total)
1 more in integration/parser/functions/require.rb (1 total)
1 more in integration/resource/catalog.rb (1 total)
1 more in unit/node.rb (1 total)
15 more in unit/parser/compiler.rb (15 total)
4 more in unit/parser/scope.rb (4 total)
2 more in unit/resource/catalog.rb (2 total)
4 more in unit/resource/type.rb (4 total)
luke:tickets/master/1943 (Combine yaml & file termini) succeeded:
* 6375698 Adding filename extension support to formats.
* 323a18c Adding client and server data dirs
* 746823a Fixing datadir defaults to match new standards
* 498a2fe Converting File terminus to use formats.
* 8d224df Removing unused Checksum::File terminus
* f2f8262 Cleaning up a test.
8050 examples, 70 failures, 44 pending
3 more in integration/checksum.rb (3 total)
1 more in unit/indirector/yaml.rb (1 total)
1 fewer in unit/node.rb (0 total)
brice:tickets/testing/2389 (Hashes) succeeded:
* b493a74 Fix #2389 - Enhance Puppet DSL with Hashes
* 8d7485a Raise an error when appending not a hash to a hash
* d4918a6 Allow adding single key to hashes
8073 examples, 70 failures, 44 pending
trying three way...
luke:tickets/testing/2954 (Class parameters) succeeded:
* 6007e46 Fixing test structure
* 0925123 Partially fixing #2954 - Adding class parameters
* 47c6f73 Changing the interface of Puppet::Resource
* 3568e4d Adding an environment helper
* cfffbfb Removing obsolete Settings comments and require
* 04241be Tuning file load order
* 325dba9 Fixing failing Environment unit tests
* 99dbcc3 Adding parameter validation to Puppet::Resource
* b5f3e6d TypeCollection now supports namespace arrays
* e93f846 Allowing Environment.new to take an environment
* ae12aba Removing :paramcheck and :typecheck settings
* d1cbaca Adding support for class parameters
* b6f3860 Removing Resource::Reference classes
* 22fa281 Adding tmpfile cleanup to tests
* 0d54704 Fixing most of the broken tests in test/
* c4c612f Adding strictness checking to resources
* 35bf666 Converging the Resource classes further
* 73a74c0 Fixing type/title resource resolution
* 54f73e3 Forcing parent evaluation in resource types
* f1b09da Finishing renaming :params to :parameters internally
* ea74a09 Resolving conflicts between luke:tickets/testing/2954 and
luke:tickets/master/2759
8170 examples, 76 failures, 44 pending
3 fewer in integration/indirector/catalog/compiler.rb (0 total)
2 fewer in integration/node.rb (0 total)
1 fewer in integration/node/facts.rb (0 total)
1 fewer in integration/resource/catalog.rb (0 total)
3 more in integration/transaction.rb (3 total)
2 fewer in unit/node/environment.rb (0 total)
8 more in unit/parser/scope.rb (12 total)
4 more in unit/resource/type.rb (8 total)
markus:feature/testing/2956 (Futures) succeeded:
* 49a0471 Added AST shim class
* b61fbd1 remove Hash.collect! diagnostics and settor? dead code
* 05c91bf instantiation, Scope#future_of, lots of plumbing
* 6292bab playing with nested scopes
* b848c7f Changes to the 0.25.x based version to make it work on
testing.
* e95af37 safeevaluate doesn't need to be passed scope
* 84739d4 removing scope from evaluate and evaluate_match
* 9503d80 fixing tests
* 50ba5a7 Resolving conflicts between markus:feature/testing/2956 and
???
8170 examples, 136 failures, 44 pending
12 more in integration/parser/collector.rb (12 total)
1 more in unit/parser/ast.rb (1 total)
2 more in unit/parser/ast/leaf.rb (2 total)
11 more in unit/parser/ast/resource.rb (11 total)
1 more in unit/parser/ast/resource_defaults.rb (1 total)
4 more in unit/parser/ast/resource_reference.rb (4 total)
3 more in unit/parser/ast/vardef.rb (3 total)
10 fewer in unit/parser/compiler.rb (5 total)
20 more in unit/parser/parser.rb (20 total)
3 more in unit/parser/resource.rb (3 total)
17 more in unit/parser/scope.rb (29 total)
2 fewer in unit/resource/catalog.rb (0 total)
2 fewer in unit/resource/type.rb (6 total)
racc warning: terminal SQTEXT used but not decleared
racc warning: terminal DQTEXT used but not decleared
markus:refactor/master/3216 (String interpolation) succeeded:
* 767639a Moving the string interpolation parsing to the parser/lexer
8185 examples, 136 failures, 44 pending
jesse:feature/master/3115 (REST, first installment) succeeded:
* b510d15 Feature #3115 REST-ified status()
8193 examples, 138 failures, 43 pending
1 more in integration/bin/puppetmasterd.rb (2 total)
1 more in unit/status.rb (1 total)
trying three way...
jesse:feature/master/3347 (XMLRPC filebucket to REST) succeeded:
* 30c256b Feature #3347 REST-ified FileBucket
8235 examples, 140 failures, 43 pending
3 fewer in integration/checksum.rb (0 total)
2 more in integration/type/file.rb (3 total)
3 more in unit/network/client/dipper.rb (3 total)
trying three way...
brice:tickets/0.25.x/3229 (regex case sensitivity) succeeded:
* 5cc5c86 Added time module to tagmail report
* 644a09e Fix #3229 - use original value in case/selector regex matching
8235 examples, 141 failures, 43 pending
1 more in unit/parser/ast/leaf.rb (3 total)
trying three way...
luke:tickets/master/3096 (internal DSL) succeeded:
* 7109c16 Adding environment support to parser resources
* 165347e Adding simplistic pure ruby interface
* f34c93e s/DSL::ResourceHelper/DSL::ResourceAPI/g
* 521f8d3 Cleaning up ResourceAPI tests
* c7814cb Adding virtual and exported resource support to the DSL
8279 examples, 168 failures, 50 pending
25 more in unit/dsl/resource_api.rb (25 total)
1 more in unit/parser/resource.rb (4 total)
1 more in unit/resource/type.rb (7 total)
ran ruby ../refactor/refactor.rb 'Miscellaneous oddity removal':
* f70f83c Code smell: Miscellaneous oddity removal
8279 examples, 168 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Inconsistent indentation and related
formatting issues':
* ae1a5f9 Code smell: Inconsistent indentation and related formatting
issues
8276 examples, 168 failures, 50 pending
1 more in unit/parser/lexer.rb (1 total)
1 fewer in unit/status.rb (0 total)
ran ruby ../refactor/refactor.rb 'Use {} for % notation delimiters wherever
practical':
* a28f6a9 Code smell: Use {} for % notation delimiters wherever
practical
8276 examples, 170 failures, 50 pending
2 more in integration/network/server/mongrel.rb (2 total)
ran ruby ../refactor/refactor.rb 'English names for special globals rather
than line-noise':
* 5aa9393 Code smell: English names for special globals rather than
line-noise
8279 examples, 168 failures, 50 pending
2 fewer in integration/network/server/mongrel.rb (0 total)
ran ruby ../refactor/refactor.rb 'Use string interpolation':
* 65add0b Code smell: Use string interpolation
8276 examples, 168 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Line modifiers are preferred to one-line
blocks.':
* 8d1aeaa Code smell: Line modifiers are preferred to one-line blocks.
8279 examples, 169 failures, 50 pending
1 more in unit/status.rb (1 total)
ran ruby ../refactor/refactor.rb 'Booleans are first class values.':
* 2cd3f87 Code smell: Booleans are first class values.
8276 examples, 210 failures, 50 pending
2 more in unit/network/client.rb (2 total)
19 more in unit/network/xmlrpc/client.rb (19 total)
1 more in unit/ssl/certificate_authority.rb (1 total)
1 fewer in unit/status.rb (0 total)
18 more in unit/transaction/report.rb (18 total)
1 more in unit/type/resources.rb (1 total)
1 more in unit/util/metric.rb (1 total)
ran ruby ../refactor/refactor.rb 'Avoid explicit returns':
*
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Avoid unneeded blocks':
*
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Omit needless checks on defined':
* 0aa55b1 Code smell: Omit needless checks on defined
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Use ||= for conditional initialization':
*
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Use &&= for dependent initialization':
*
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb "Don't restate results directly after
assignment":
*
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Avoid needless decorations':
* 350a628 Code smell: Avoid needless decorations
8276 examples, 210 failures, 50 pending
ran ruby ../refactor/refactor.rb 'Two space indentation':
* 7b98e09 Code smell: Two space indentation
8276 examples, 208 failures, 50 pending
2 fewer in unit/type/schedule.rb (0 total)
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
