On Wed, 2010-03-17 at 16:38 -0700, Luke Kanies wrote: > You've got a spare 'put's in there, but otherwise, +1.
OK, I'll remove this in a new version. > Do you think this might be just the wrong way of doing this matching > overall? My instincts around graphs seem to be particularly horrible, > so there's probably a much better way to do this. I must admit I'm not good in graphs at all. I even didn't try to understand the whole concept of the SimpleGraph, I just tried to micro-optimize the piece that was given me troubles. But I think that even if the current implementation can be slow simetimes (and fine in most cases), it is working fine, so I doubt the implementation is incorrect. Maybe there can be a better implementation or layout, but since I'm more than ignorant about graph data structures/algorithms, my advices won't be that useful :-) -- Brice Figureau Follow the latest Puppet Community evolutions on www.planetpuppet.org! -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
