On Mon, 2010-04-12 at 21:58 -0700, Luke Kanies wrote:
> +1
> 
> The construct that includes a blank module vs. the compression module  
> is a bit weird.  You don't necessarily need to change it, but might it  
> be simpler if you just had a hook that allowed you to conditionally  
> include it or not?

Yes, I suck at metaprogramming, but the good news is that I started
reading the book :-)

So you're proposing something like this:

module Puppet::Network::HTTP::Compression

   def include_compression
       include Puppet.features.zlib? ? Active : None
   end
   ...
end

And then use include_compression in the other classes.
-- 
Brice Figureau
Follow the latest Puppet Community evolutions on www.planetpuppet.org!

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-...@googlegroups.com.
To unsubscribe from this group, send email to 
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to