> I'm not sure to understand the use of these trailing dots I removed with > the > 2nd patch. As there isn't many tests for this function, maybe this breaks > something else and needs more work. >
I'm not sure either, but looking at it I'm dubious of the regex anyway; specifically, the "0x\d+" segment, as "0x" is usually used to introduce a hex number, and yet "\d+" will only match a string of decimal digits. Thus the regex as given will match "0x007" correctly, but not "0xff", and will match "0x0d" incorrectly (it will just see the "0x0" but not the "d"). I don't know enough about the context to say if this matters (e.g. the value may always be either 0x0 or 0x1 or something) but it looks wrong. -- Markus -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
