+1 to the patch, since I paired on it. As for the sort performance: We've already got a sort on the left side of the comparison (elsewhere in the code), so, from a computer science point of view, it has the same big-O performance. Also, this array is the list of groups that a user is a member of, which is usually has fewer than 100 elements, so anything we do on it will be pretty fast.
~Jesse On Tue, May 18, 2010 at 1:37 PM, Steven Jenkins <[email protected]>wrote: > On Tue, May 18, 2010 at 2:44 PM, Matt Robinson <[email protected]> > wrote: > > LDAP group membership comparison was happening on an unsorted string. > > Sorting the string for now, may want to do something smarter by > > comparing something other than strings later. > > > > Do you really want to sort all the time? Won't that end up being a > performance hit (often) unnecessarily? > > Steven > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<puppet-dev%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
