On Thu, 2010-07-22 at 20:47 -0700, Markus Roberts wrote:
> -1 unfortunately.
> 
> This makes known resources per-thread instead of per-environment,
> which means that we'll loose all environment specificity--the resource
> types would then be the same for all environments.  :(
> 
> Making it per thread x environment doesn't quite work either, at least
> in the most obvious (too me) extrapolation.
> 
> I'll try to come up with a counter-patch this evening.

Yes, I realized the patch was wrong during the night, but felt too lazy
to powerup the computer to send a -1 e-mail myself to protect my
honor :-)

The patch is wrong because I assumed a thread was short-lived and would
assume only a compilation which is plain wrong if the http middle-ware
is using any sort of thread-pooling.

Also the patch suffers (like the original version) from a race-condition
around stale? and perform_initial_import.

So, sorry to send the wrong patch.
-- 
Brice Figureau
Follow the latest Puppet Community evolutions on www.planetpuppet.org!

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to