> +1 based on reviewing the diff, running the tests, and your comment in > #4649 that these flags aren't actually needed for the subset of > event-loop that we actually use.
To be clear there are a couple of "apparently" qualifiers in there. I wasn't able to find a case where we needed them, but neither was I able to prove we didn't. However, the patch shouldn't change behaviour at all on posix systems so the real possibility is that some as-yet-unidentified edge cases may fail under MS Windows -- but that's true even without the patch. -- M ----------------------------------------------------------- The power of accurate observation is commonly called cynicism by those who have not got it. ~George Bernard Shaw ------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
