On Wed, Oct 6, 2010 at 1:54 PM, Jacob Helwig <[email protected]> wrote:
> While I agree that early returns, and temp variables _can_ be harder to > read, I think they have the opposite effect in this case. The original > lines are long enough and complex enough that I think they deserve to be > broken up, and I think the usage of early returns, and a temp variable > is a perfectly valid way to do so (though you should still be careful to > not go too far in that direction). > > I'm +1 for Paul's suggestion here. > I'm going to try to come up with a revised version of the patch this week that addresses the issues Jesse and I came up with in the code review. I'll pay particular attention to speed testing the downstream_from_vertex() and upstream_from_vertex() methods so that we don't wind up unduly sacrificing speed for readability. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
