On Thu, Dec 16, 2010 at 17:52, Andrew Forgue <[email protected]> wrote:
> Here's a new version of it.
Thanks so much. I looked over the code, and I can't see anything
objectionable to it. It looks like it does the right thing™ in all
cases, and allows the right sort of SRV record lookup override.
The one thing I am not certain about - and it is a kind of "what
colour is your bikeshed" question - is that you have the config option
specify '_puppet._tcp.$domain'.
It might make sense to specify the "$domain" part of the lookup, but
make _puppet._tcp automatic - that isn't really an optional bit of the
label that gets searched for, after all. OTOH, it doesn't *hurt*
anything to do it this way...
So, yeah: I would be happy with it as-is, or just specifying the
non-protocol part of the SRV record, as you prefer.
That all looks great!
Daniel
--
✣ Daniel Pittman ✉ [email protected] ☎ +61 401 155 707
♽ made with 100 percent post-consumer electrons
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
