I've been trying to wrap my head around this and have some ideas. 1) Obviously, size is a dead giveaway if something changed. 2) Yes, we do need to store checksum and size when we write a file 3) For any file object where the content is in the catalog (i.e. we're using content =>) then we should pass along the appropriate type of hash in the catalog.
Doing #3 will allow for a direct comparison of the old hash to the new hash *and* preclude us from having to actually calculate the hash on the client since it can just be copied from what the server gave you! I think this will give us the most gain for 99% of all file cases right now since file serving was such a dog until the 2.6 series. Opines? Trevor On Fri, Jan 7, 2011 at 2:34 PM, Brice Figureau <[email protected]> wrote: > On 29/12/10 12:41, Trevor Vaughan wrote: >> [snipped] >> >> I'm thinking that size+time (similar to rsync) might be enough for most >> files on a system. There will be relatively few files on a system that >> you'll want to do a full checksum on. > > In fact, I'm not so sure. Most puppetd runs don't change anything to the > host (at least in my own setup). If we ever implement size+time, then > we'd still have to md5 the files because size+time would match for every > managed file. > > Anyway, I'll try this week-end to summarize how many times we checksum a > given source/content file and see if we can squeeze some time... > > -- > Brice Figureau > My Blog: http://www.masterzen.fr/ > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 [email protected] -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
