On Mon, Jan 17, 2011 at 09:28, James Turnbull <[email protected]> wrote:
> Timeouts are now disabled by specifying 0.
[...]
> + if value =~ /^\-\d+$/
> + Puppet.notice "Negative timeouts are deprecated and should be
> replaced with 0."
> + value = 0
> + end
Nice to see this is actually fixing the problem, not just whining
about it; I actually had to look twice to find that out, though,
because the choice of "should be replaced" in the message had me
thinking that it was simply suggesting this, not actually fixing it.
Perhaps something more like:
Negative timeouts are deprecated; we have forced the timeout to
zero, but please update your configuration.
I think that is less likely to confuse someone reading it about what
has happened, and what they should do next.
Otherwise, a big +1 for actually fixing it on the fly, and the patch
looks good to me.
Regards,
Daniel
--
✉ Daniel Pittman <[email protected]>
⌨ [email protected] (XMPP)
☎ +1 503 893 2285
♻ made with 100 percent post-consumer electrons
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
