On Mon, Feb 14, 2011 at 11:24 PM, Daniel Pittman <[email protected]> wrote: > On Mon, Feb 14, 2011 at 22:20, Nan Liu <[email protected]> wrote: >> >> Minor fix since this seems very straightfoward. Still need project manager >> to review bug request first. > > You need a better commit message; this makes sense now, but in six > months time when I go back in time to work out why we did this it will > make zero sense. You need to explain the *why* of the commit, not > either the what, or the how. > >> lib/puppet/type/service.rb | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/lib/puppet/type/service.rb b/lib/puppet/type/service.rb >> index 3ef0449..b89223f 100644 >> --- a/lib/puppet/type/service.rb >> +++ b/lib/puppet/type/service.rb >> @@ -63,6 +63,8 @@ module Puppet >> >> aliasvalue(:false, :stopped) >> aliasvalue(:true, :running) >> + aliasvalue(:absent, :stopped) >> + aliasvalue(:present, :running) > > This allows me to say this, right? > > service { "foo": ensure => absent } > > That doesn't make sense to me. The service will not be absent at the > end of the process, only stopped; I think this adds aliases that are > more confusing than helpful in context.
++ I'm actually on the verge of rejecting the original bug report. I don't believe absent/present are useful synonyms for the Service resource. > > Regards, > Daniel > -- > ⎋ Puppet Labs Developer – http://puppetlabs.com > ✉ Daniel Pittman <[email protected]> > ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 > ♲ Made with 100 percent post-consumer electrons > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
