On Wed, Mar 2, 2011 at 12:47 PM, James Turnbull <ja...@lovedthanlost.net>wrote:
> The kick application has the option to ping hosts. On 1.9.x this
> code was returning "Invalid next". The next in this code has been
> replaced with an exit. Testing has confirmed this doesn't change the
> behavior of puppet kick.
>
+1
The original code is wrong in 1.8.x as well, but we just weren't catching
it. The overall structure sucks IMHO, but it sucks significantly less with
this change.
>
> Signed-off-by: James Turnbull <ja...@lovedthanlost.net>
> ---
> lib/puppet/application/kick.rb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/puppet/application/kick.rb
> b/lib/puppet/application/kick.rb
> index 37aeb1e..a55884a 100644
> --- a/lib/puppet/application/kick.rb
> +++ b/lib/puppet/application/kick.rb
> @@ -104,7 +104,7 @@ class Puppet::Application::Kick < Puppet::Application
> out = %x{ping -c 1 #{host}}
> unless $CHILD_STATUS == 0
> $stderr.print "Could not contact #{host}\n"
> - next
> + exit($CHILD_STATUS)
> end
> end
>
> --
> 1.7.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "Puppet Developers" group.
> To post to this group, send email to puppet-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> puppet-dev+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/puppet-dev?hl=en.
>
>
--
-----------------------------------------------------------
When in trouble or in doubt, run in circles,
scream and shout. -- 1920's parody of the
maritime general prudential rule
------------------------------------------------------------
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
