Paul Nasrat wrote:
> On 7 March 2011 09:25, James Turnbull <ja...@lovedthanlost.net> wrote:
>> Signed-off-by: James Turnbull <ja...@lovedthanlost.net>
>
>
> This fact probably could do with a unittest - there is selinux_spec.rb
> already and you should be able to add the missing test as you are
> touching it.
Sure.
>
> Perhaps use Resolution::Exec rather than %x{}
Good point.
>
> We also should enforce the no-trailing whitespace rules in the facter
> lib not in each individual fact. I personally dislike the use of pipes
> in the fact as we can't unittest the logic, and would rather it be
> handled in ruby rather than grep/awk.
Yeah I thought about this but probably won't do it globally in a point
release. This solves the problem for this release and there is a ticket
for global management of this assigned to 1.6.0 or 2.0.0.
James
--
James Turnbull
Puppet Labs
1-503-734-8571
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
