Hi Juerg, On 21/03/11 03:54, Juerg Walz wrote: > > Signed-off-by: Juerg Walz <jw...@pobox.com> > --- > Local-branch: tickets/master/4258-dev > lib/puppet/provider/package/pkgutil.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/puppet/provider/package/pkgutil.rb > b/lib/puppet/provider/package/pkgutil.rb > index 350cacc..97625f2 100755 > --- a/lib/puppet/provider/package/pkgutil.rb > +++ b/lib/puppet/provider/package/pkgutil.rb > @@ -38,7 +38,7 @@ Puppet::Type.type(:package).provide :pkgutil, :parent => > :sun, :source => :sun d > # Create a second instance with the alias if it's different > pkgalias = aliases[pkg[:name]] > if pkgalias and pkg[:name] != pkgalias > - apkg = Hash.new(pkg) > + apkg = pkg > apkg[:name] = pkgalias > pkginsts << new(apkg) > end
Thanks for the testing - what issue did you run into with this? I'd started with something similar (that is, just changing :name in pkg and supplying that to 'new') but when using it for real in Puppet, I think it broke cases where using the full package name (CSWsvn) when an alias was present (subversion). I'll go back and test both cases at some point and perhaps we can create a test to show the issue. Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
