On Mon, Mar 28, 2011 at 10:27 AM, Daniel Pittman <dan...@puppetlabs.com>wrote:

> On Sun, Mar 27, 2011 at 20:09, Ben Hughes <b...@puppetlabs.com> wrote:
> >
> > Signed-off-by: Ben Hughes <b...@puppetlabs.com>
> > ---
> > Local-branch: tickets/master/6832
> >  install.rb |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/install.rb b/install.rb
> > index eb91e7c..42acfb9 100755
> > --- a/install.rb
> > +++ b/install.rb
> > @@ -119,7 +119,7 @@ def check_prereqs
> >         begin
> >             require pre
> >         rescue LoadError
> > -            puts "Could not load %s; cannot install" % pre
> > +            puts "Could not load %s Ruby library; cannot install" % pre
>
> So, this looks solid and correct, but is a touch off in terms of our
> usual process:
>
> You should structure the commit summary "(#1234) foo bar baz" to
> identify the ticket uniquely about this particular issue.  If there
> isn't one, make one, unless it really was part of #6832, in which case
> it should be another commit in the same series.
>

http://projects.puppetlabs.com/projects/puppet/wiki/Development_Lifecycle#Commit+Messages

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to 
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to