On Mon, Apr 11, 2011 at 19:51, Nigel Kersten <ni...@puppetlabs.com> wrote: > On Mon, Apr 11, 2011 at 7:39 PM, Daniel Pittman <dan...@puppetlabs.com> wrote: >> On Mon, Apr 11, 2011 at 18:57, Nigel Kersten <ni...@puppetlabs.com> wrote:
> I basically wanted to rehabilitate this broken provider, and > concentrated just on being able to ensure versions, as revisions are > largely hidden from view for most users. > > This provider was actually broken for most use cases, I don't mean > "broken" in the sense of "doesn't work the way I would like it to" :) *nod* I don't think this is bad enough to keep out, just that it still has a box of rusty knives and broken glass sitting *right* there where users are likely to step, and I think we can hide that a tiny bit more to save them. :) > Variants make this more complicated, as the "version" string becomes: > version_revision+variant(s) > and I didn't want to deal with parsing that out in this iteration, or > overload the version/ensure field with the variant. Yeah, good call. I was more concerned that we enforce the simple things we do, and then relax, than we add more features right now though. […] >> Since you work the office over, give me a yell if you want some >> on-the-spot advice on using those when you are writing tests. They >> can make for a *much* nicer bunch of feature testing, used right. :) >> >> Otherwise, great change. Thanks for writing that! > > Will do. Test plumbing like this is something I struggle with regularly. > > We really should do a clean-up of our existing tests so fools like me > don't keep copying bad practice :) I am working through it, improving where I can. The biggest stopper is that it is potentially quite a lot of work, and the ROI is actually relatively hard to see in the short term. It makes for cleaner code, but doesn't radically improve anything much else until people start working on new tests. :( Daniel -- ⎋ Puppet Labs Developer – http://puppetlabs.com ✉ Daniel Pittman <dan...@puppetlabs.com> ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
