B --

> +RSpec::Matchers.define :allow do |request|
> +
> +  match do |auth|
> +    begin
> +      auth.allowed?(request)
> +      true
> +    rescue => detail
> +      false
> +    end
> +  end

I'm not at all up to speed on RSpec matchers but this looks odd -- as if
allow will pass anything that doesn't raise an error, even if
"auth.allowed?(request)" returns false.  Should perhaps the "true" line
be removed, or am I just missing the intent?

-- Markus


-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to 
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to