Many spec tests fail on Windows because there are no default
providers implemented for Windows yet. Several others are
failing due to Puppet::Util::Cacher not working correctly,
so for now the tests that are known to fail are marked with
:fails_on_windows => true. To skip these tests, you can run:
rspec --tag ~fails_on_windows spec
Reviewed-by: Jacob Helwig <ja...@puppetlabs.com>
Signed-off-by: Josh Cooper <j...@puppetlabs.com>
---
Local-branch: feature/master/8268-puppet-agent-windows
spec/integration/application/doc_spec.rb | 2 +-
.../file_serving/terminus_helper_spec.rb | 2 +-
.../indirector/direct_file_server_spec.rb | 2 +-
.../indirector/file_content/file_server_spec.rb | 2 +-
.../indirector/file_metadata/file_server_spec.rb | 2 +-
spec/integration/parser/compiler_spec.rb | 2 +-
spec/integration/parser/ruby_manifest_spec.rb | 2 +-
spec/integration/provider/mount_spec.rb | 2 +-
spec/integration/provider/package_spec.rb | 2 +-
.../provider/ssh_authorized_key_spec.rb | 2 +-
spec/integration/resource/type_collection_spec.rb | 2 +-
spec/integration/ssl/certificate_authority_spec.rb | 2 +-
spec/integration/ssl/certificate_request_spec.rb | 2 +-
.../ssl/certificate_revocation_list_spec.rb | 2 +-
spec/integration/ssl/host_spec.rb | 2 +-
spec/integration/type/file_spec.rb | 26 ++++++++++----------
spec/integration/type/tidy_spec.rb | 2 +-
spec/integration/util/autoload_spec.rb | 2 +-
spec/unit/application/inspect_spec.rb | 2 +-
spec/unit/application/master_spec.rb | 2 +-
spec/unit/configurer/downloader_spec.rb | 2 +-
spec/unit/file_bucket/dipper_spec.rb | 2 +-
spec/unit/file_serving/configuration_spec.rb | 2 +-
.../unit/indirector/certificate_request/ca_spec.rb | 2 +-
.../indirector/certificate_status/file_spec.rb | 2 +-
spec/unit/indirector/file_bucket_file/file_spec.rb | 2 +-
spec/unit/indirector/resource/ral_spec.rb | 2 +-
spec/unit/indirector/resource_type/parser_spec.rb | 4 +-
spec/unit/network/http_pool_spec.rb | 2 +-
spec/unit/property_spec.rb | 2 +-
spec/unit/provider/exec/shell_spec.rb | 2 +-
spec/unit/provider/host/parsed_spec.rb | 2 +-
spec/unit/provider/mount/parsed_spec.rb | 2 +-
.../provider/ssh_authorized_key/parsed_spec.rb | 4 +-
spec/unit/provider/user/user_role_add_spec.rb | 2 +-
spec/unit/provider/user/useradd_spec.rb | 2 +-
spec/unit/resource/catalog_spec.rb | 2 +-
spec/unit/ssl/host_spec.rb | 2 +-
spec/unit/ssl/inventory_spec.rb | 2 +-
spec/unit/sslcertificates/ca_spec.rb | 2 +-
spec/unit/transaction/report_spec.rb | 2 +-
spec/unit/type/exec_spec.rb | 4 +-
spec/unit/type/file/content_spec.rb | 2 +-
spec/unit/type/file/source_spec.rb | 2 +-
spec/unit/type/file_spec.rb | 2 +-
spec/unit/type/group_spec.rb | 2 +-
spec/unit/type/host_spec.rb | 2 +-
spec/unit/type/mount_spec.rb | 10 ++++----
spec/unit/type/resources_spec.rb | 2 +-
spec/unit/type/user_spec.rb | 2 +-
spec/unit/util/execution_stub_spec.rb | 2 +-
spec/unit/util/logging_spec.rb | 4 +-
spec/unit/util/run_mode_spec.rb | 2 +-
53 files changed, 73 insertions(+), 73 deletions(-)
mode change 100644 => 100755
spec/integration/provider/ssh_authorized_key_spec.rb
diff --git a/spec/integration/application/doc_spec.rb
b/spec/integration/application/doc_spec.rb
index 9412976..47fd93a 100755
--- a/spec/integration/application/doc_spec.rb
+++ b/spec/integration/application/doc_spec.rb
@@ -5,7 +5,7 @@ require 'puppet_spec/files'
describe Puppet::Application::Doc do
include PuppetSpec::Files
- it "should not generate an error when module dir overlaps parent of site.pp
(#4798)", :'fails_on_ruby_1.9.2' => true do
+ it "should not generate an error when module dir overlaps parent of site.pp
(#4798)", :'fails_on_ruby_1.9.2' => true, :fails_on_windows => true do
begin
# Note: the directory structure below is more complex than it
# needs to be, but it's representative of the directory structure
diff --git a/spec/integration/file_serving/terminus_helper_spec.rb
b/spec/integration/file_serving/terminus_helper_spec.rb
index 7500b1f..99fee9c 100755
--- a/spec/integration/file_serving/terminus_helper_spec.rb
+++ b/spec/integration/file_serving/terminus_helper_spec.rb
@@ -10,7 +10,7 @@ class TerminusHelperIntegrationTester
end
end
-describe Puppet::FileServing::TerminusHelper do
+describe Puppet::FileServing::TerminusHelper, :fails_on_windows => true do
it "should be able to recurse on a single file" do
@path = Tempfile.new("fileset_integration")
request = Puppet::Indirector::Request.new(:metadata, :find, @path.path,
:recurse => true)
diff --git a/spec/integration/indirector/direct_file_server_spec.rb
b/spec/integration/indirector/direct_file_server_spec.rb
index 0dd9c82..68ed007 100755
--- a/spec/integration/indirector/direct_file_server_spec.rb
+++ b/spec/integration/indirector/direct_file_server_spec.rb
@@ -34,7 +34,7 @@ describe Puppet::Indirector::DirectFileServer, " when
interacting with the files
end
end
-describe Puppet::Indirector::DirectFileServer, " when interacting with
FileServing::Fileset and the model" do
+describe Puppet::Indirector::DirectFileServer, " when interacting with
FileServing::Fileset and the model", :fails_on_windows => true do
before do
@terminus = Puppet::Indirector::FileContent::File.new
diff --git a/spec/integration/indirector/file_content/file_server_spec.rb
b/spec/integration/indirector/file_content/file_server_spec.rb
index 88d2345..2a8c134 100755
--- a/spec/integration/indirector/file_content/file_server_spec.rb
+++ b/spec/integration/indirector/file_content/file_server_spec.rb
@@ -10,7 +10,7 @@ require 'shared_behaviours/file_server_terminus'
require 'puppet_spec/files'
-describe Puppet::Indirector::FileContent::FileServer, " when finding files" do
+describe Puppet::Indirector::FileContent::FileServer, " when finding files",
:fails_on_windows => true do
it_should_behave_like "Puppet::Indirector::FileServerTerminus"
include PuppetSpec::Files
diff --git a/spec/integration/indirector/file_metadata/file_server_spec.rb
b/spec/integration/indirector/file_metadata/file_server_spec.rb
index 9e84134..5259837 100755
--- a/spec/integration/indirector/file_metadata/file_server_spec.rb
+++ b/spec/integration/indirector/file_metadata/file_server_spec.rb
@@ -8,7 +8,7 @@ require 'spec_helper'
require 'puppet/indirector/file_metadata/file_server'
require 'shared_behaviours/file_server_terminus'
-describe Puppet::Indirector::FileMetadata::FileServer, " when finding files" do
+describe Puppet::Indirector::FileMetadata::FileServer, " when finding files",
:fails_on_windows => true do
it_should_behave_like "Puppet::Indirector::FileServerTerminus"
before do
diff --git a/spec/integration/parser/compiler_spec.rb
b/spec/integration/parser/compiler_spec.rb
index 9f6aae9..51611f8 100755
--- a/spec/integration/parser/compiler_spec.rb
+++ b/spec/integration/parser/compiler_spec.rb
@@ -13,7 +13,7 @@ describe Puppet::Parser::Compiler do
Puppet.settings.clear
end
- it "should be able to determine the configuration version from a local
version control repository" do
+ it "should be able to determine the configuration version from a local
version control repository", :fails_on_windows => true do
# This should always work, because we should always be
# in the puppet repo when we run this.
version = %x{git rev-parse HEAD}.chomp
diff --git a/spec/integration/parser/ruby_manifest_spec.rb
b/spec/integration/parser/ruby_manifest_spec.rb
index 7f3bb71..b04baf5 100755
--- a/spec/integration/parser/ruby_manifest_spec.rb
+++ b/spec/integration/parser/ruby_manifest_spec.rb
@@ -4,7 +4,7 @@ require 'spec_helper'
require 'tempfile'
require 'puppet_spec/files'
-describe "Pure ruby manifests" do
+describe "Pure ruby manifests", :fails_on_windows => true do
include PuppetSpec::Files
before do
diff --git a/spec/integration/provider/mount_spec.rb
b/spec/integration/provider/mount_spec.rb
index 4af0dca..eb8cc13 100755
--- a/spec/integration/provider/mount_spec.rb
+++ b/spec/integration/provider/mount_spec.rb
@@ -2,7 +2,7 @@ require 'spec_helper'
require 'puppet/file_bucket/dipper'
-describe "mount provider (integration)" do
+describe "mount provider (integration)", :fails_on_windows => true do
include PuppetSpec::Files
def create_fake_fstab(initially_contains_entry)
diff --git a/spec/integration/provider/package_spec.rb
b/spec/integration/provider/package_spec.rb
index 5fecdf1..7017523 100755
--- a/spec/integration/provider/package_spec.rb
+++ b/spec/integration/provider/package_spec.rb
@@ -12,7 +12,7 @@ describe "Package Provider", :'fails_on_ruby_1.9.2' => true do
lambda { pkg.provider.install }.should raise_error
end
- it "should be able to get a list of existing packages" do
+ it "should be able to get a list of existing packages",
:fails_on_windows => true do
provider.instances.each do |package|
package.should be_instance_of(provider)
package.properties[:provider].should == provider.name
diff --git a/spec/integration/provider/ssh_authorized_key_spec.rb
b/spec/integration/provider/ssh_authorized_key_spec.rb
old mode 100644
new mode 100755
index 902f9ad..f7f61ab
--- a/spec/integration/provider/ssh_authorized_key_spec.rb
+++ b/spec/integration/provider/ssh_authorized_key_spec.rb
@@ -3,7 +3,7 @@
require 'spec_helper'
require 'puppet/file_bucket/dipper'
-describe "ssh_authorized_key provider (integration)" do
+describe "ssh_authorized_key provider (integration)", :fails_on_windows =>
true do
include PuppetSpec::Files
before :each do
diff --git a/spec/integration/resource/type_collection_spec.rb
b/spec/integration/resource/type_collection_spec.rb
index 6ea2e7f..0852a98 100755
--- a/spec/integration/resource/type_collection_spec.rb
+++ b/spec/integration/resource/type_collection_spec.rb
@@ -4,7 +4,7 @@ require 'spec_helper'
require 'puppet_spec/files'
require 'puppet/resource/type_collection'
-describe Puppet::Resource::TypeCollection do
+describe Puppet::Resource::TypeCollection, :fails_on_windows => true do
describe "when autoloading from modules" do
include PuppetSpec::Files
diff --git a/spec/integration/ssl/certificate_authority_spec.rb
b/spec/integration/ssl/certificate_authority_spec.rb
index c5e1454..c6ff58e 100755
--- a/spec/integration/ssl/certificate_authority_spec.rb
+++ b/spec/integration/ssl/certificate_authority_spec.rb
@@ -8,7 +8,7 @@ require 'spec_helper'
require 'puppet/ssl/certificate_authority'
require 'tempfile'
-describe Puppet::SSL::CertificateAuthority do
+describe Puppet::SSL::CertificateAuthority, :fails_on_windows => true do
before do
# Get a safe temporary file
file = Tempfile.new("ca_integration_testing")
diff --git a/spec/integration/ssl/certificate_request_spec.rb
b/spec/integration/ssl/certificate_request_spec.rb
index 688466c..31bb48d 100755
--- a/spec/integration/ssl/certificate_request_spec.rb
+++ b/spec/integration/ssl/certificate_request_spec.rb
@@ -8,7 +8,7 @@ require 'spec_helper'
require 'puppet/ssl/certificate_request'
require 'tempfile'
-describe Puppet::SSL::CertificateRequest do
+describe Puppet::SSL::CertificateRequest, :fails_on_windows => true do
before do
# Get a safe temporary file
file = Tempfile.new("csr_integration_testing")
diff --git a/spec/integration/ssl/certificate_revocation_list_spec.rb
b/spec/integration/ssl/certificate_revocation_list_spec.rb
index 051a815..95f0e63 100755
--- a/spec/integration/ssl/certificate_revocation_list_spec.rb
+++ b/spec/integration/ssl/certificate_revocation_list_spec.rb
@@ -8,7 +8,7 @@ require 'spec_helper'
require 'puppet/ssl/certificate_revocation_list'
require 'tempfile'
-describe Puppet::SSL::CertificateRevocationList do
+describe Puppet::SSL::CertificateRevocationList, :fails_on_windows => true do
before do
# Get a safe temporary file
file = Tempfile.new("ca_integration_testing")
diff --git a/spec/integration/ssl/host_spec.rb
b/spec/integration/ssl/host_spec.rb
index e9c37c1..2da5bcf 100755
--- a/spec/integration/ssl/host_spec.rb
+++ b/spec/integration/ssl/host_spec.rb
@@ -8,7 +8,7 @@ require 'spec_helper'
require 'puppet/ssl/host'
require 'tempfile'
-describe Puppet::SSL::Host do
+describe Puppet::SSL::Host, :fails_on_windows => true do
before do
# Get a safe temporary file
file = Tempfile.new("host_integration_testing")
diff --git a/spec/integration/type/file_spec.rb
b/spec/integration/type/file_spec.rb
index 1a328b0..241861c 100755
--- a/spec/integration/type/file_spec.rb
+++ b/spec/integration/type/file_spec.rb
@@ -23,7 +23,7 @@ describe Puppet::Type.type(:file) do
end
describe "when writing files" do
- it "should backup files to a filebucket when one is configured" do
+ it "should backup files to a filebucket when one is configured",
:fails_on_windows => true do
bucket = Puppet::Type.type(:filebucket).new :path =>
tmpfile("filebucket"), :name => "mybucket"
file = Puppet::Type.type(:file).new :path => tmpfile("bucket_backs"),
:backup => "mybucket", :content => "foo"
catalog = Puppet::Resource::Catalog.new
@@ -73,7 +73,7 @@ describe Puppet::Type.type(:file) do
File.read(file[:path]).should == "bar\n"
end
- it "should not backup symlinks" do
+ it "should not backup symlinks", :fails_on_windows => true do
link = tmpfile("link")
dest1 = tmpfile("dest1")
dest2 = tmpfile("dest2")
@@ -110,7 +110,7 @@ describe Puppet::Type.type(:file) do
File.read(File.join(backup, "foo")).should == "yay"
end
- it "should backup directories to filebuckets by backing up each file
separately" do
+ it "should backup directories to filebuckets by backing up each file
separately", :fails_on_windows => true do
bucket = Puppet::Type.type(:filebucket).new :path =>
tmpfile("filebucket"), :name => "mybucket"
file = Puppet::Type.type(:file).new :path => tmpfile("bucket_backs"),
:backup => "mybucket", :content => "foo", :force => true
catalog = Puppet::Resource::Catalog.new
@@ -172,7 +172,7 @@ describe Puppet::Type.type(:file) do
end
end
- it "should be able to recurse over a nonexistent file" do
+ it "should be able to recurse over a nonexistent file", :fails_on_windows
=> true do
@path = tmpfile("file_integration_tests")
@file = Puppet::Type::File.new(
@@ -214,7 +214,7 @@ describe Puppet::Type.type(:file) do
end
end
- it "should be able to recursively make links to other files" do
+ it "should be able to recursively make links to other files",
:fails_on_windows => true do
source = tmpfile("file_link_integration_source")
build_path(source)
@@ -241,7 +241,7 @@ describe Puppet::Type.type(:file) do
end
end
- it "should be able to recursively copy files" do
+ it "should be able to recursively copy files", :fails_on_windows => true do
source = tmpfile("file_source_integration_source")
build_path(source)
@@ -289,7 +289,7 @@ describe Puppet::Type.type(:file) do
(File.stat(file).mode & 007777).should == 0644
end
- it "should recursively manage files even if there is an explicit file
whose name is a prefix of the managed file" do
+ it "should recursively manage files even if there is an explicit file
whose name is a prefix of the managed file", :fails_on_windows => true do
dir = tmpfile("recursion_vs_explicit_2")
managed = File.join(dir, "file")
@@ -309,7 +309,7 @@ describe Puppet::Type.type(:file) do
end
end
- describe "when generating resources" do
+ describe "when generating resources", :fails_on_windows => true do
before do
@source = tmpfile("generating_in_catalog_source")
@@ -349,7 +349,7 @@ describe Puppet::Type.type(:file) do
describe "when copying files" do
# Ticket #285.
- it "should be able to copy files with pound signs in their names" do
+ it "should be able to copy files with pound signs in their names",
:fails_on_windows => true do
source = tmpfile("filewith#signs")
dest = tmpfile("destwith#signs")
@@ -366,7 +366,7 @@ describe Puppet::Type.type(:file) do
File.read(dest).should == "foo"
end
- it "should be able to copy files with spaces in their names" do
+ it "should be able to copy files with spaces in their names",
:fails_on_windows => true do
source = tmpfile("filewith spaces")
dest = tmpfile("destwith spaces")
@@ -385,7 +385,7 @@ describe Puppet::Type.type(:file) do
(File.stat(dest).mode & 007777).should == 0755
end
- it "should be able to copy individual files even if recurse has been
specified" do
+ it "should be able to copy individual files even if recurse has been
specified", :fails_on_windows => true do
source = tmpfile("source")
dest = tmpfile("dest")
@@ -434,7 +434,7 @@ describe Puppet::Type.type(:file) do
File.read(dest).should == "this is some content, yo"
end
- it "should delete files with sources but that are set for deletion" do
+ it "should delete files with sources but that are set for deletion",
:fails_on_windows => true do
dest = tmpfile("dest_source_with_ensure")
source = tmpfile("source_source_with_ensure")
File.open(source, "w") { |f| f.puts "yay" }
@@ -455,7 +455,7 @@ describe Puppet::Type.type(:file) do
File.should_not be_exist(dest)
end
- describe "when purging files" do
+ describe "when purging files", :fails_on_windows => true do
before do
@sourcedir = tmpfile("purge_source")
@destdir = tmpfile("purge_dest")
diff --git a/spec/integration/type/tidy_spec.rb
b/spec/integration/type/tidy_spec.rb
index 675aaf4..08a2409 100755
--- a/spec/integration/type/tidy_spec.rb
+++ b/spec/integration/type/tidy_spec.rb
@@ -12,7 +12,7 @@ describe Puppet::Type.type(:tidy) do
end
# Testing #355.
- it "should be able to remove dead links" do
+ it "should be able to remove dead links", :fails_on_windows => true do
dir = tmpfile("tidy_link_testing")
link = File.join(dir, "link")
target = tmpfile("no_such_file_tidy_link_testing")
diff --git a/spec/integration/util/autoload_spec.rb
b/spec/integration/util/autoload_spec.rb
index 92fc655..771e6a7 100755
--- a/spec/integration/util/autoload_spec.rb
+++ b/spec/integration/util/autoload_spec.rb
@@ -94,7 +94,7 @@ describe Puppet::Util::Autoload do
}
end
- it "should be able to load files directly from modules" do
+ it "should be able to load files directly from modules", :fails_on_windows
=> true do
modulepath = tmpfile("autoload_module_testing")
libdir = File.join(modulepath, "mymod", "lib", "foo")
FileUtils.mkdir_p(libdir)
diff --git a/spec/unit/application/inspect_spec.rb
b/spec/unit/application/inspect_spec.rb
index 571683f..15a3bee 100755
--- a/spec/unit/application/inspect_spec.rb
+++ b/spec/unit/application/inspect_spec.rb
@@ -142,7 +142,7 @@ describe Puppet::Application::Inspect do
@inspect.run_command
end
- it "should not send unreadable files" do
+ it "should not send unreadable files", :fails_on_windows => true do
File.open(@file, 'w') { |f| f.write('stuff') }
File.chmod(0, @file)
Puppet::FileBucketFile::Rest.any_instance.expects(:head).never
diff --git a/spec/unit/application/master_spec.rb
b/spec/unit/application/master_spec.rb
index e36df8c..636988f 100755
--- a/spec/unit/application/master_spec.rb
+++ b/spec/unit/application/master_spec.rb
@@ -5,7 +5,7 @@ require 'puppet/application/master'
require 'puppet/daemon'
require 'puppet/network/server'
-describe Puppet::Application::Master do
+describe Puppet::Application::Master, :fails_on_windows => true do
before :each do
@master = Puppet::Application[:master]
@daemon = stub_everything 'daemon'
diff --git a/spec/unit/configurer/downloader_spec.rb
b/spec/unit/configurer/downloader_spec.rb
index 1ffea9b..8bb6a3d 100755
--- a/spec/unit/configurer/downloader_spec.rb
+++ b/spec/unit/configurer/downloader_spec.rb
@@ -122,7 +122,7 @@ describe Puppet::Configurer::Downloader do
@dler = Puppet::Configurer::Downloader.new("foo", @dl_name, source_name)
end
- it "should not skip downloaded resources when filtering on tags" do
+ it "should not skip downloaded resources when filtering on tags",
:fails_on_windows => true do
Puppet[:tags] = 'maytag'
@dler.evaluate
diff --git a/spec/unit/file_bucket/dipper_spec.rb
b/spec/unit/file_bucket/dipper_spec.rb
index 4b4c08c..431b123 100755
--- a/spec/unit/file_bucket/dipper_spec.rb
+++ b/spec/unit/file_bucket/dipper_spec.rb
@@ -34,7 +34,7 @@ describe Puppet::FileBucket::Dipper do
lambda { @dipper.backup(file) }.should raise_error(Puppet::Error)
end
- it "should backup files to a local bucket" do
+ it "should backup files to a local bucket", :fails_on_windows => true do
Puppet[:bucketdir] = "/non/existent/directory"
file_bucket = tmpdir("bucket")
diff --git a/spec/unit/file_serving/configuration_spec.rb
b/spec/unit/file_serving/configuration_spec.rb
index d76ac9c..ed86638 100755
--- a/spec/unit/file_serving/configuration_spec.rb
+++ b/spec/unit/file_serving/configuration_spec.rb
@@ -3,7 +3,7 @@ require 'spec_helper'
require 'puppet/file_serving/configuration'
-describe Puppet::FileServing::Configuration do
+describe Puppet::FileServing::Configuration, :fails_on_windows => true do
it "should make :new a private method" do
proc { Puppet::FileServing::Configuration.new }.should raise_error
end
diff --git a/spec/unit/indirector/certificate_request/ca_spec.rb
b/spec/unit/indirector/certificate_request/ca_spec.rb
index ebd64a2..fb758b5 100755
--- a/spec/unit/indirector/certificate_request/ca_spec.rb
+++ b/spec/unit/indirector/certificate_request/ca_spec.rb
@@ -10,7 +10,7 @@ require 'puppet/sslcertificates'
require 'puppet/sslcertificates/ca'
require 'puppet/indirector/certificate_request/ca'
-describe Puppet::SSL::CertificateRequest::Ca do
+describe Puppet::SSL::CertificateRequest::Ca, :fails_on_windows => true do
include PuppetSpec::Files
before :each do
diff --git a/spec/unit/indirector/certificate_status/file_spec.rb
b/spec/unit/indirector/certificate_status/file_spec.rb
index ae03aa9..897fe07 100755
--- a/spec/unit/indirector/certificate_status/file_spec.rb
+++ b/spec/unit/indirector/certificate_status/file_spec.rb
@@ -4,7 +4,7 @@ require 'puppet/ssl/host'
require 'puppet/indirector/certificate_status'
require 'tempfile'
-describe "Puppet::Indirector::CertificateStatus::File" do
+describe "Puppet::Indirector::CertificateStatus::File", :fails_on_windows =>
true do
include PuppetSpec::Files
before do
diff --git a/spec/unit/indirector/file_bucket_file/file_spec.rb
b/spec/unit/indirector/file_bucket_file/file_spec.rb
index eb86eee..ee0b61a 100755
--- a/spec/unit/indirector/file_bucket_file/file_spec.rb
+++ b/spec/unit/indirector/file_bucket_file/file_spec.rb
@@ -14,7 +14,7 @@ describe Puppet::FileBucketFile::File do
Puppet::FileBucketFile::File.doc.should be_instance_of(String)
end
- describe "non-stubbing tests" do
+ describe "non-stubbing tests", :fails_on_windows => true do
include PuppetSpec::Files
before do
diff --git a/spec/unit/indirector/resource/ral_spec.rb
b/spec/unit/indirector/resource/ral_spec.rb
index cf746cb..e38745f 100755
--- a/spec/unit/indirector/resource/ral_spec.rb
+++ b/spec/unit/indirector/resource/ral_spec.rb
@@ -2,7 +2,7 @@
require 'spec_helper'
describe "Puppet::Resource::Ral" do
- describe "find" do
+ describe "find", :fails_on_windows => true do
before do
@request = stub 'request', :key => "user/root"
end
diff --git a/spec/unit/indirector/resource_type/parser_spec.rb
b/spec/unit/indirector/resource_type/parser_spec.rb
index fa2aa10..67ea73f 100755
--- a/spec/unit/indirector/resource_type/parser_spec.rb
+++ b/spec/unit/indirector/resource_type/parser_spec.rb
@@ -25,7 +25,7 @@ describe Puppet::Indirector::ResourceType::Parser do
@terminus.find(@request).should == type
end
- it "should attempt to load the type if none is found in memory" do
+ it "should attempt to load the type if none is found in memory",
:fails_on_windows => true do
dir = tmpdir("find_a_type")
FileUtils.mkdir_p(dir)
Puppet[:modulepath] = dir
@@ -122,7 +122,7 @@ describe Puppet::Indirector::ResourceType::Parser do
@terminus.search(@request).should be_nil
end
- it "should load all resource types from all search paths" do
+ it "should load all resource types from all search paths",
:fails_on_windows => true do
dir = tmpdir("searching_in_all")
first = File.join(dir, "first")
second = File.join(dir, "second")
diff --git a/spec/unit/network/http_pool_spec.rb
b/spec/unit/network/http_pool_spec.rb
index c5d3e04..32c7a90 100755
--- a/spec/unit/network/http_pool_spec.rb
+++ b/spec/unit/network/http_pool_spec.rb
@@ -83,7 +83,7 @@ describe Puppet::Network::HttpPool do
Puppet::Network::HttpPool.http_instance("me", 54321, true)
end
- it "should have a mechanism for clearing the http cache" do
+ it "should have a mechanism for clearing the http cache",
:fails_on_windows => true do
stub_settings :http_proxy_host => "myhost", :http_proxy_port => 432,
:configtimeout => 120
old = Puppet::Network::HttpPool.http_instance("me", 54321)
Puppet::Network::HttpPool.http_instance("me", 54321).should equal(old)
diff --git a/spec/unit/property_spec.rb b/spec/unit/property_spec.rb
index 7728b5d..99d4bc7 100755
--- a/spec/unit/property_spec.rb
+++ b/spec/unit/property_spec.rb
@@ -109,7 +109,7 @@ describe Puppet::Property do
end
end
- describe "when creating an event" do
+ describe "when creating an event", :fails_on_windows => true do
before do
@event = Puppet::Transaction::Event.new
diff --git a/spec/unit/provider/exec/shell_spec.rb
b/spec/unit/provider/exec/shell_spec.rb
index 90047b9..4e1f002 100755
--- a/spec/unit/provider/exec/shell_spec.rb
+++ b/spec/unit/provider/exec/shell_spec.rb
@@ -3,7 +3,7 @@ require 'spec_helper'
provider_class = Puppet::Type.type(:exec).provider(:shell)
-describe provider_class do
+describe provider_class, :fails_on_windows => true do
before :each do
@resource = Puppet::Resource.new(:exec, 'foo')
@provider = provider_class.new(@resource)
diff --git a/spec/unit/provider/host/parsed_spec.rb
b/spec/unit/provider/host/parsed_spec.rb
index 9cb5890..fa41d82 100755
--- a/spec/unit/provider/host/parsed_spec.rb
+++ b/spec/unit/provider/host/parsed_spec.rb
@@ -6,7 +6,7 @@ require 'puppet_spec/files'
provider_class = Puppet::Type.type(:host).provider(:parsed)
-describe provider_class do
+describe provider_class, :fails_on_windows => true do
include PuppetSpec::Files
before do
diff --git a/spec/unit/provider/mount/parsed_spec.rb
b/spec/unit/provider/mount/parsed_spec.rb
index 7831dae..fdee2ef 100755
--- a/spec/unit/provider/mount/parsed_spec.rb
+++ b/spec/unit/provider/mount/parsed_spec.rb
@@ -8,7 +8,7 @@ require 'shared_behaviours/all_parsedfile_providers'
provider_class = Puppet::Type.type(:mount).provider(:parsed)
-describe provider_class do
+describe provider_class, :fails_on_windows => true do
before :each do
@mount_class = Puppet::Type.type(:mount)
diff --git a/spec/unit/provider/ssh_authorized_key/parsed_spec.rb
b/spec/unit/provider/ssh_authorized_key/parsed_spec.rb
index bd5e55a..8a7fe75 100755
--- a/spec/unit/provider/ssh_authorized_key/parsed_spec.rb
+++ b/spec/unit/provider/ssh_authorized_key/parsed_spec.rb
@@ -128,7 +128,7 @@ describe provider_class do
end
end
- describe "and a user has been specified with no target" do
+ describe "and a user has been specified with no target", :fails_on_windows
=> true do
before :each do
@resource[:user] = "nobody"
#
@@ -189,7 +189,7 @@ describe provider_class do
end
end
- describe "and a invalid user has been specified with no target" do
+ describe "and a invalid user has been specified with no target",
:fails_on_windows => true do
it "should catch an exception and raise a Puppet error" do
@resource[:user] = "thisusershouldnotexist"
diff --git a/spec/unit/provider/user/user_role_add_spec.rb
b/spec/unit/provider/user/user_role_add_spec.rb
index 5f2fc30..c44fc5a 100755
--- a/spec/unit/provider/user/user_role_add_spec.rb
+++ b/spec/unit/provider/user/user_role_add_spec.rb
@@ -3,7 +3,7 @@ require 'spec_helper'
provider_class = Puppet::Type.type(:user).provider(:user_role_add)
-describe provider_class do
+describe provider_class, :fails_on_windows => true do
before do
@resource = stub("resource", :name => "myuser", :managehome? => nil)
@resource.stubs(:should).returns "fakeval"
diff --git a/spec/unit/provider/user/useradd_spec.rb
b/spec/unit/provider/user/useradd_spec.rb
index 724fc12..4265ee3 100755
--- a/spec/unit/provider/user/useradd_spec.rb
+++ b/spec/unit/provider/user/useradd_spec.rb
@@ -3,7 +3,7 @@ require 'spec_helper'
provider_class = Puppet::Type.type(:user).provider(:useradd)
-describe provider_class do
+describe provider_class, :fails_on_windows => true do
before do
@resource = stub("resource", :name => "myuser", :managehome? => nil)
@resource.stubs(:should).returns "fakeval"
diff --git a/spec/unit/resource/catalog_spec.rb
b/spec/unit/resource/catalog_spec.rb
index 35b2fea..5b914da 100755
--- a/spec/unit/resource/catalog_spec.rb
+++ b/spec/unit/resource/catalog_spec.rb
@@ -509,7 +509,7 @@ describe Puppet::Resource::Catalog, "when compiling" do
@catalog.resource(:file, @basepath+"/something").should equal(resource)
end
- it "should not create aliases for resources non-isomorphic resources whose
names do not match their titles" do
+ it "should not create aliases for resources non-isomorphic resources whose
names do not match their titles", :fails_on_windows => true do
resource = Puppet::Type.type(:exec).new(:title => "testing", :command =>
"echo", :path => %w{/bin /usr/bin /usr/local/bin})
@catalog.add_resource(resource)
diff --git a/spec/unit/ssl/host_spec.rb b/spec/unit/ssl/host_spec.rb
index c2d9690..e168094 100755
--- a/spec/unit/ssl/host_spec.rb
+++ b/spec/unit/ssl/host_spec.rb
@@ -5,7 +5,7 @@ require 'puppet/ssl/host'
require 'puppet/sslcertificates'
require 'puppet/sslcertificates/ca'
-describe Puppet::SSL::Host do
+describe Puppet::SSL::Host, :fails_on_windows => true do
before do
Puppet::SSL::Host.indirection.terminus_class = :file
@host = Puppet::SSL::Host.new("myname")
diff --git a/spec/unit/ssl/inventory_spec.rb b/spec/unit/ssl/inventory_spec.rb
index d8606b1..3d141d0 100755
--- a/spec/unit/ssl/inventory_spec.rb
+++ b/spec/unit/ssl/inventory_spec.rb
@@ -118,7 +118,7 @@ describe Puppet::SSL::Inventory do
end
end
- describe "and formatting a certificate" do
+ describe "and formatting a certificate", :fails_on_windows => true do
before do
@cert = stub 'cert', :not_before => Time.now, :not_after => Time.now,
:subject => "mycert", :serial => 15
end
diff --git a/spec/unit/sslcertificates/ca_spec.rb
b/spec/unit/sslcertificates/ca_spec.rb
index eea246b..2ff4036 100755
--- a/spec/unit/sslcertificates/ca_spec.rb
+++ b/spec/unit/sslcertificates/ca_spec.rb
@@ -5,7 +5,7 @@ require 'puppet'
require 'puppet/sslcertificates'
require 'puppet/sslcertificates/ca'
-describe Puppet::SSLCertificates::CA do
+describe Puppet::SSLCertificates::CA, :fails_on_windows => true do
before :all do
@hosts = %w{host.domain.com Other.Testing.Com}
end
diff --git a/spec/unit/transaction/report_spec.rb
b/spec/unit/transaction/report_spec.rb
index 08b892f..033c4c7 100755
--- a/spec/unit/transaction/report_spec.rb
+++ b/spec/unit/transaction/report_spec.rb
@@ -208,7 +208,7 @@ describe Puppet::Transaction::Report do
end
describe "for times" do
- it "should provide the total amount of time for each resource type" do
+ it "should provide the total amount of time for each resource type",
:fails_on_windows => true do
add_statuses(3, :file) do |status|
status.evaluation_time = 1
end
diff --git a/spec/unit/type/exec_spec.rb b/spec/unit/type/exec_spec.rb
index 175e307..2861bb0 100755
--- a/spec/unit/type/exec_spec.rb
+++ b/spec/unit/type/exec_spec.rb
@@ -169,7 +169,7 @@ describe Puppet::Type.type(:exec) do
end
end
- describe "when setting user" do
+ describe "when setting user", :fails_on_windows => true do
it "should fail if we are not root" do
Puppet.features.stubs(:root?).returns(false)
expect { Puppet::Type.type(:exec).new(:name => @command, :user =>
'input') }.
@@ -188,7 +188,7 @@ describe Puppet::Type.type(:exec) do
describe "when setting group" do
shared_examples_for "exec[:group]" do
['one', 2, 'wheel', 4294967295, 4294967296].each do |value|
- it "should accept '#{value}' without error or judgement" do
+ it "should accept '#{value}' without error or judgement",
:fails_on_windows => true do
type = Puppet::Type.type(:exec).new(:name => @command, :group =>
value)
type[:group].should == value
end
diff --git a/spec/unit/type/file/content_spec.rb
b/spec/unit/type/file/content_spec.rb
index 7af5f9d..6a2f3f4 100755
--- a/spec/unit/type/file/content_spec.rb
+++ b/spec/unit/type/file/content_spec.rb
@@ -298,7 +298,7 @@ describe content do
end
end
- describe "from local source" do
+ describe "from local source", :fails_on_windows => true do
before(:each) do
@resource = Puppet::Type.type(:file).new :path => @filename, :backup
=> false
@sourcename = tmpfile('source')
diff --git a/spec/unit/type/file/source_spec.rb
b/spec/unit/type/file/source_spec.rb
index efa7c13..5129d1e 100755
--- a/spec/unit/type/file/source_spec.rb
+++ b/spec/unit/type/file/source_spec.rb
@@ -39,7 +39,7 @@ describe Puppet::Type.type(:file).attrclass(:source) do
source.new(:resource => @resource).must respond_to(:metadata=)
end
- describe "when returning the metadata" do
+ describe "when returning the metadata", :fails_on_windows => true do
before do
@metadata = stub 'metadata', :source= => nil
end
diff --git a/spec/unit/type/file_spec.rb b/spec/unit/type/file_spec.rb
index 3a01d09..f416e98 100755
--- a/spec/unit/type/file_spec.rb
+++ b/spec/unit/type/file_spec.rb
@@ -305,7 +305,7 @@ describe Puppet::Type.type(:file) do
file[:path].should == "X:/"
end
- it "should add a slash to a drive letter", :'fails_on_ruby_1.9.2' =>
true do
+ it "should add a slash to a drive letter", :'fails_on_windows' => true,
:'fails_on_ruby_1.9.2' => true do
file = Puppet::Type::File.new(:path => "X:")
file[:path].should == "X:/"
end
diff --git a/spec/unit/type/group_spec.rb b/spec/unit/type/group_spec.rb
index afe2824..3b6cac8 100755
--- a/spec/unit/type/group_spec.rb
+++ b/spec/unit/type/group_spec.rb
@@ -1,7 +1,7 @@
#!/usr/bin/env rspec
require 'spec_helper'
-describe Puppet::Type.type(:group) do
+describe Puppet::Type.type(:group), :fails_on_windows => true do
before do
ENV["PATH"] += File::PATH_SEPARATOR + "/usr/sbin" unless
ENV["PATH"].split(File::PATH_SEPARATOR).include?("/usr/sbin")
@class = Puppet::Type.type(:group)
diff --git a/spec/unit/type/host_spec.rb b/spec/unit/type/host_spec.rb
index 602c428..145fb27 100755
--- a/spec/unit/type/host_spec.rb
+++ b/spec/unit/type/host_spec.rb
@@ -34,7 +34,7 @@ describe host do
end
- describe "when validating values" do
+ describe "when validating values", :fails_on_windows => true do
it "should support present as a value for ensure" do
proc { @class.new(:name => "foo", :ensure => :present) }.should_not
raise_error
end
diff --git a/spec/unit/type/mount_spec.rb b/spec/unit/type/mount_spec.rb
index 9ef7699..3309cd2 100755
--- a/spec/unit/type/mount_spec.rb
+++ b/spec/unit/type/mount_spec.rb
@@ -1,7 +1,7 @@
#!/usr/bin/env rspec
require 'spec_helper'
-describe Puppet::Type.type(:mount) do
+describe Puppet::Type.type(:mount), :fails_on_windows => true do
it "should have a :refreshable feature that requires the :remount method" do
Puppet::Type.type(:mount).provider_feature(:refreshable).methods.should ==
[:remount]
end
@@ -16,7 +16,7 @@ describe Puppet::Type.type(:mount) do
end
end
-describe Puppet::Type.type(:mount), "when validating attributes" do
+describe Puppet::Type.type(:mount), "when validating attributes",
:fails_on_windows => true do
[:name, :remounts, :provider].each do |param|
it "should have a #{param} parameter" do
Puppet::Type.type(:mount).attrtype(param).should == :param
@@ -30,7 +30,7 @@ describe Puppet::Type.type(:mount), "when validating
attributes" do
end
end
-describe Puppet::Type.type(:mount)::Ensure, "when validating values" do
+describe Puppet::Type.type(:mount)::Ensure, "when validating values",
:fails_on_windows => true do
before do
@provider = stub 'provider', :class =>
Puppet::Type.type(:mount).defaultprovider, :clear => nil
Puppet::Type.type(:mount).defaultprovider.expects(:new).returns(@provider)
@@ -62,7 +62,7 @@ describe Puppet::Type.type(:mount)::Ensure, "when validating
values" do
end
end
-describe Puppet::Type.type(:mount)::Ensure do
+describe Puppet::Type.type(:mount)::Ensure, :fails_on_windows => true do
before :each do
provider_properties = {}
@provider = stub 'provider', :class =>
Puppet::Type.type(:mount).defaultprovider, :clear => nil, :satisfies? => true,
:name => :mock, :property_hash => provider_properties
@@ -279,7 +279,7 @@ describe Puppet::Type.type(:mount)::Ensure do
end
end
-describe Puppet::Type.type(:mount), "when modifying an existing mount entry" do
+describe Puppet::Type.type(:mount), "when modifying an existing mount entry",
:fails_on_windows => true do
before do
@provider = stub 'provider', :class =>
Puppet::Type.type(:mount).defaultprovider, :clear => nil, :satisfies? => true,
:name => :mock, :remount => nil
Puppet::Type.type(:mount).defaultprovider.stubs(:new).returns(@provider)
diff --git a/spec/unit/type/resources_spec.rb b/spec/unit/type/resources_spec.rb
index 48c068c..5e9396b 100755
--- a/spec/unit/type/resources_spec.rb
+++ b/spec/unit/type/resources_spec.rb
@@ -21,7 +21,7 @@ describe resources do
end
end
- describe "#generate" do
+ describe "#generate", :fails_on_windows => true do
before do
@host1 = Puppet::Type.type(:host).new(:name => 'localhost', :ip =>
'127.0.0.1')
@catalog = Puppet::Resource::Catalog.new
diff --git a/spec/unit/type/user_spec.rb b/spec/unit/type/user_spec.rb
index 71c9e18..2da755e 100755
--- a/spec/unit/type/user_spec.rb
+++ b/spec/unit/type/user_spec.rb
@@ -3,7 +3,7 @@ require 'spec_helper'
user = Puppet::Type.type(:user)
-describe user do
+describe user, :fails_on_windows => true do
before do
ENV["PATH"] += File::PATH_SEPARATOR + "/usr/sbin" unless
ENV["PATH"].split(File::PATH_SEPARATOR).include?("/usr/sbin")
@provider = stub 'provider'
diff --git a/spec/unit/util/execution_stub_spec.rb
b/spec/unit/util/execution_stub_spec.rb
index 3498768..9cd15ca 100755
--- a/spec/unit/util/execution_stub_spec.rb
+++ b/spec/unit/util/execution_stub_spec.rb
@@ -16,7 +16,7 @@ describe Puppet::Util::ExecutionStub do
Puppet::Util::ExecutionStub.current_value.should == nil
end
- it "should restore normal execution after 'reset' is called" do
+ it "should restore normal execution after 'reset' is called",
:fails_on_windows => true do
true_command = Puppet::Util.which('true') # Note: "true" exists at
different paths in different OSes
stub_call_count = 0
Puppet::Util::ExecutionStub.set do |command, options|
diff --git a/spec/unit/util/logging_spec.rb b/spec/unit/util/logging_spec.rb
index 6a77e70..2953f54 100755
--- a/spec/unit/util/logging_spec.rb
+++ b/spec/unit/util/logging_spec.rb
@@ -46,7 +46,7 @@ describe Puppet::Util::Logging do
@logger.notice "foo"
end
- it "should use the path of any provided resource type" do
+ it "should use the path of any provided resource type", :fails_on_windows
=> true do
resource = Puppet::Type.type(:mount).new :name => "foo"
resource.expects(:path).returns "/path/to/mount".to_sym
@@ -56,7 +56,7 @@ describe Puppet::Util::Logging do
resource.notice "foo"
end
- it "should use the path of any provided resource parameter" do
+ it "should use the path of any provided resource parameter",
:fails_on_windows => true do
resource = Puppet::Type.type(:mount).new :name => "foo"
param = resource.parameter(:name)
diff --git a/spec/unit/util/run_mode_spec.rb b/spec/unit/util/run_mode_spec.rb
index c8d2b31..883ee12 100755
--- a/spec/unit/util/run_mode_spec.rb
+++ b/spec/unit/util/run_mode_spec.rb
@@ -1,7 +1,7 @@
#!/usr/bin/env rspec
require 'spec_helper'
-describe Puppet::Util::RunMode do
+describe Puppet::Util::RunMode, :fails_on_windows => true do
before do
@run_mode = Puppet::Util::RunMode.new('fake')
end
--
1.7.5.4
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
