Inspect reports are inherently different from apply reports, and the
non-expandable-bullet icon (indicating "all good" in an apply report)
looks very misleading for an audited resource with no properties.  This
change replaces the standard green bullet with a red one on inspect
reports alone.

Reviewed-By: Daniel Pittman

Signed-off-by: Pieter van de Bruggen <[email protected]>
---
Local-branch: tickets/1.2rc/8544
 app/views/reports/show.html.haml   |    2 +-
 public/images/icons/bullet_red.png |  Bin 0 -> 1068 bytes
 public/stylesheets/tables.css      |    5 +++++
 3 files changed, 6 insertions(+), 1 deletions(-)
 create mode 100644 public/images/icons/bullet_red.png

diff --git a/app/views/reports/show.html.haml b/app/views/reports/show.html.haml
index 4a8bb37..eb97d1b 100644
--- a/app/views/reports/show.html.haml
+++ b/app/views/reports/show.html.haml
@@ -1,4 +1,4 @@
 #sidebar= render 'shared/node_manager_sidebar'
 #main
-  .item
+  .item{ :class => @report ? @report.kind + '-report' : '' }
     = render 'report', :report => @report
diff --git a/public/images/icons/bullet_red.png 
b/public/images/icons/bullet_red.png
new file mode 100644
index 
0000000000000000000000000000000000000000..66dac03f6c58b94328aed6cf097efe1f532ea48c
GIT binary patch
literal 1068
zcmV+{1k?M8P)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV00004XF*Lt006JZ
zHwB960008+X+uL$Nkc;*P;zf(X>4Tx0C)j~RL^S@K@|QrZmG~B2wH0nvUrdpNm;9C
zMbtL^5n^i$+aI<?kYqDS)^0ZI?k2URh~(nYD&9ryp$Gqf9(wR(FG_`4MJV2@C}N=(
zE%D86Otz)!z|Ma2-Z$@kZ+71R4RX>n^?(HA4aZWV5ov6ELTdbo0FI&wK{O>*+w4vx
z20?>!`FrQsdJlnHR>OPycd~b_n$otK2Za4V;76L-DzNVtaSB-y0*E}{p()372;bw_
z^6ZZ}PI-92wGS&j#91PIKs7DSe@(bk%_Y-7gGe}(^>I=@oY#w#*Bu9GZf3^F5WP>3
zrn}7Ut74&?PWBFvy`A)aPP5)V!Xd&78LdA?xQ(9mjMYElVd13a#D+Z_7&Y|xU=_C-
zsrWU*6kiZcC!$nw*)9$7n6CX+@=AhmkT}X@VSsa5NKe;HZuq)~1$`#h6R+ZTR#D-3
zj}vF!)ZOnz+5)dI4jl{{44Mr{P!L4~VVJN`K!!XTF*LGrKO?IK8<Tr7btG!LbYeuY
zL3=jbJ-1P$-8}v%B5{;MwFr{@LH;VQ$xr2Z`O93e*jD$Ht(%&<^58qg<(at}9@o>z
z<8w`3e3jI8lUGNUta*C8n(P`s>{pjD=7Kek#B;Fw@hxAK%$F&Q6vg9J^Xf~4by_hu
z-=A!MJ3Znq&n~srbFGPsH&&aMXZ>nO`|hf|ljc?VPhR!${AbO?W8x_>CU%PFA&Hm8
zF7cAsOREdwU~R_;ot1_u(ruCYB-LPGn!NQdT|ZlRy+(fw^-+`=%+gee_kY4FWHg<*
z4sZI8+sFJD<oAl_pC|$^Y~aY5x@}W&?+~G7rEYVs0vEs0eekw!YomTR`~+A$s}`+N
zHJ>270UUORdLHO0nA4V)%{fwsET5CQ>B?eK%uw4yQc~9?*JVo<vzb+5>2}ze(;aRc
zp*ceL#HUJSllrgm5wQKRQu+C;QrUh^8rFfA`ftFz{YAidi-`aL010qNS#tmY3ljhU
z3ljkVnw%H_007iUL_t(I5$%#W4#F@HMSoBb1xw3Pa0)ukkt@*U4B;HP0EH_g8Ynpd
z5;YPCgh&xVa1zIH7MwO3s&oiTQ`qu*Gy1ksmL;03Rui~le?VYT8C-39(l(2Q$}=l3
z6cQzw{|?>xYJIQYCj}Ken$8^b#z39|ud}m1ZYy?K7my*Qxw6n50>K4%o`6mtkrY-P
zuJ)ursszXcpmY_5o<f2rF~!pYo(hKGraKRGb%Dsog9nT<kQs<Lb$5piVm)>w6L=wK
mUL;&fVEn%_{R&iA-_AZA_*hl^`jA2Z0000<MNUMnLSTY#E$5#A

literal 0
HcmV?d00001

diff --git a/public/stylesheets/tables.css b/public/stylesheets/tables.css
index 344a778..ee8285e 100644
--- a/public/stylesheets/tables.css
+++ b/public/stylesheets/tables.css
@@ -142,9 +142,14 @@ table td.empty {
 .expandable-list .expandable-link:before {
   content: url('../../images/icons/bullet_toggle_minus.png');
 }
+
 .expandable-list .non-expandable-bullet:before {
   content: url('../../images/icons/bullet_green.png');
 }
+.inspect-report .expandable-list .non-expandable-bullet:before {
+  content: url('../../images/icons/bullet_red.png');
+}
+
 .expandable-list .expandable-link, .expandable-list .non-expandable-bullet {
   vertical-align: bottom;
 }
-- 
1.7.5.1

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to