I tried to login to redmine with openid, but just got an "internal error".
Here's the report:
When having unresolved parameter collisions in the dashboard,
lib/node_group_graph throws and error:
ActionView::TemplateError (undefined method `first' for #<Set:
{#<NodeGroup id:6, name:"GROUPNANE">}>) on line #4 of
app/views/shared/_parameters.html.haml:
1: .section
2: %h3 Parameters
3: - # Conflicting parameters are okay here, since we just want to warn
4: - unless resource.compiled_parameters(true).empty?
5: - if resource.errors.on(:parameters)
6: %p.error
7: %strong Warning:
lib/node_group_graph.rb:98:in `compiled_parameters'
lib/node_group_graph.rb:95:in `each'
lib/node_group_graph.rb:95:in `compiled_parameters'
lib/node_group_graph.rb:133:in `yield_children'
lib/node_group_graph.rb:137:in `walk'
lib/node_group_graph.rb:120:in `walk_parent_groups'
lib/node_group_graph.rb:83:in `compiled_parameters'
The fix is to do this:
source = nil
parameter.sources.each { |s| source ||= s }
inherited[parameter.name].sources << source
instead of this:
inherited[parameter.name].sources << parameter.sources.first
With the fix, the dashboard correctly displays the conflict error at the
top of the node's page.
The dashboard is running on Scientific Linux 5, a RHEL5 clone, with ruby
1.8.5(?). But I don't think that is relevant, I couldn't find Set.first
in 1.9's docs.
Best Regards, David
On 29.07.2011 06:16, Matt Robinson wrote:
Good catch, I've gone ahead and swapped the column order and merged
the change, so we should be ready for another RC tomorrow unless
anyone finds more issues.
On Thu, Jul 28, 2011 at 4:51 PM, Daniel Hogland<dhogl...@puppetlabs.com> wrote:
Another bug that might want to be fixed (quick fix i'm sure) before cutting
a new rc is 8691.
Dan
On Thu, Jul 28, 2011 at 4:38 PM, Matt Robinson<m...@puppetlabs.com> wrote:
A race condition issue has been found with DelayedJob report
processing. The fix has been committed to the rc branch, so another
RC will be necessary.
Ticket #8686
commit:e86526f224058d8d049b2f8b93d5fdca57332ad8
On Fri, Jul 22, 2011 at 4:18 PM, Michael Stahnke<stah...@puppetlabs.com>
wrote:
This a feature release candidate (number 3) of Puppet Dashboard. If
you're wondering what happened to rc2, it was internal only. Our CI
system found a few issues before we released it to the public.
This release is available for download at:
http://downloads.puppetlabs.com/dashboard/
We have included Debian and RPM packages as well as a tarball.
See the Verifying Puppet Download section at:
http://projects.puppetlabs.com/projects/puppet/wiki/Downloading_Puppet
Please report feedback via the Puppet Labs Redmine site, using an
affected version of 1.2rc3
http://projects.puppetlabs.com/projects/dashboard
Documentation is available at:
http://docs.puppetlabs.com/dashboard/index.html
Highlights of RC3:
===
* Documentation moved primarily away from the included README to
website: http://docs.puppetlabs.com/dashboard/index.html
* Some minor UI bug fixes
Commits for RC3
===
88771ec (#8589) Report events are now ordered by name.
8bd0ffb (#8544) Make empty inspected resources "red".
d036276 (#8505) Update the default date stringification.
bb99ed9 Properly Quote RAILS_ROOT in get_app_version method
08717e1 (#8508) Add delayed job worker script for debian/ubuntu package
2eef4f4 (#8529) Remove unneeded a print statement from sass.rb
af8b6e9 (#8500) Replace README with a smaller one
dff2256 (#8499) Update the usage of mktemp in Rakefile to work on mac
3f0afca (#8484) "Nodes for this group" heading now appears correctly
1.2 series
====
Highlights Include:
* Moved to Apache 2.0 License
* LOTS of UI improvements
* Updated version of Rails
* Now Requires Ruby 1.8.7
* Has Delayed Jobs (puppet-dashboard-workers) for async actions
* Several performance improvements
More Details
===
d389d8b (#7568) Relicense to Apache-2.0 License
57d0122 (#8276) Remove MaRuKu dependency
a44d9ff (#8262) Show node groups even when node classification is
disabled
3996b29 (#8262) Create callbacks for each section of node_classification
partial
5dac13a (#8199) Move 'failed' resources to the top when viewing report
events
2a3a73c (#7967) Improved user-facing design for delayed job warnings
c78b85a (#8266) Back-end logic for splitting read and unread DJ
failures.
15bba31 (#8121) Properly generate CSS from SASS in production.
a9abf41 (#8101) Updated to new version of Tipsy plugin
9cb5e55 (Maint) More generalized tabbed interface
fbe11aa (#8196) Adjust content width based on body classes.
e756c25 (#8196) Add a body class describing sidebar state.
23cbef1 (#8196) Clean up body class manipulation.
3670e2b (#8146) Change default DASHBOARD_URL in external_node to
localhost
81ec3c0 (#8090) Update .gitignore to ignore plugin files
6f117fc (#8022) Don't fail when installing plugin without `public`
directory
07a9407 (#8022) Create a hook for plugins to add items to<head> in
layout
64be352 (#7967) Add default value for read column of
delayed_job_failures
240c548 (#7967) Infrastructure for displaying background failures.
8038cce (#7389) Don't auto-start DelayedJob workers.
933ae04 (#7389) Cheaper unique filenames for spooled reports.
b4384eb (#7398) Support externally managed DelayedJob workers.
184e65b (#7689) Rake task to support parallel report POSTing.
2333c08 (#5947) Rename Destroy button to Delete
2fb0ac1 (#7976) Fixed static debug data in view
393970d (#7976) Node filter links in sidebar work in all cases
4ba3d23 (#7398) Configurable DelayedJob worker count.
e839884 (#7938) Delayed import from file, not YAML string.
d24c323 (#7973) Refactor colors for changed/unchanged
58c2b52 (#7398) Use DelayedJob for background processing.
6aefc60 (#7938) Add daemons gem to support DelayedJob
7395369 (#7398) Vendor DelayedJob for background tasks.
05040d9 (#7958) Allow plugins to add top level navigation
c4d2f26 (#7597) Better integration of node summaries
4ad9cbc (#7913) Upgrade rspec and rspec-rails vendored gems
c09b650 (#7913) Fix tap deprecation warning
d88da0e (#7913) Update README to say we only support Ruby 1.8.7
acdc31f (#7913) upgrade will_paginate gem to avoid deprecation warnings
e935b8d (#7913) vendor newer version of RDoc
ce9be98 (#7913) Fix deprecation warning for config.load_paths
dd8f277 (#7913) Upgrade vendored haml gem and vendor sass
dd88d74 (#7913) vendor json_pure since it was an undocumented dependency
789c1b7 (#7913) Upgrading from Rails 2.3.4 to 2.3.12
060799f (#7597) Reformat node view CSV link
3726771 (#7280) Edit outdated information about the inventory service
a02113a (#7597) Change empty tab display, report tab ordering, link
expansion
b62bf4c (#7597) Add count to pagination link, fix duplicate tags
9f06f58 (#7597) Display only relevant columns in node tables
96bb99c (#7597) Add "help" link to node summary.
95f870e (#6992) Add totals row for resource status counts to node view
44a145c (#7544) Group report resources by status
c2e2c63 (#7840) Increase consistency of status definitions and remove
old code
dd5e610 (#7674) Add pending to the run status stacked bar graph
a58d06d (#6992) Show a summary of nodes x resources on home page.
9d71cd2 (#7630) Denormalize ResourceStatus status and count calculations
6e03872 (#6528) Cleanup implementation of `::words`.
2b53c29 (#6528) Remove hideous Array monkeypatch.
0312ea2 (#7007) Stream node CSV download
87b3e91 (#7007) Add a link to the home page to download nodes in CSV
1af5e86 (#7007) Add support for CSV to nodes index
2829a8b (#7007) Add custom CSV output for nodes with resources
11aa643 (#7007) Use a custom property list for ResourceStatus.to_csv
fc0fe85 (#7007) Add support for CSV output
d2184e4 (#7537) Use #titleize for report tab names.
12b035d (#7537) Add reasonable defaults for report tab names.
b230077 (#7560) Clean up the Dashboard index for 0 nodes.
6fe8513 (#6991) Add the Node Status summary graph.
8e70035 (#6991) Massage Node named scopes.
57d6b6b (#6991) Cleanup of excessively long lines.
db61b1b (#6537) Add a pending scope to nodes
552c760 (#5126) Support HTTP basic auth in bin/external_node
a85c681 (#6537) Add a pending scope to nodes
cf1410a (#6988) rpm should include logrotate file
0ff2373 (#7209) Require naming convention for plugin migration files
8ff11be (#7161) Add a route to create node group memberships
ec9e879 (#7161) Remove forgery protection
6c700c1 (#4816) Add a Node#find_by_id_or_name helper
d540cc6 (#6989) Improve messages for empty tabs.
b36bfb6 (#6989) Squash bugs in IE{7,8}.
16d6fad (#6989) Fix font rendering in Firefox.
0f2723b (#6989) Add basic styling for tabs.
31984aa (#6989) Remove a call to Registry.each_callback.
4d2f9c7 (#6989) Remove ugly<Proc instance>#name hack.
b8f5a04 (#6989) Refactor user-facing names.
04153bc (#6989) Refactor Javascript into application.js
cc43e61 (#6989) Add "tabs" for report sections.
--
You received this message because you are subscribed to the Google
Groups "Puppet Users" group.
To post to this group, send email to puppet-us...@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
--
Join us for PuppetConf, September 22nd and 23rd in Portland, OR
http://bit.ly/puppetconfsig
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-us...@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
--
You received this message because you are subscribed to the Google Groups "Puppet
Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
