[Puppet-dev] (puppetlabs/facter) New pull request: (maint) Add kernel stubbing for is_virtual fact spec

[wearetherobots]

Greetings!

Please review the pull request #37: (maint) Add kernel stubbing for is_virtual fact spec opened by (adrienthebo)

Some more information about the pull request:

• Opened: Tue Aug 30 17:47:18 UTC 2011
• Based on: puppetlabs:master (df0c5804489c3026650217effebe9e755de99c5e)
• Requested merge: adrienthebo:maint/master/add_kernel_stubbing_for_is_virtual_tests (0bf827f11a6cce82a009c136a8b4e3f6dbf44c15)

Description:

The kernel fact needs to be stubbed out since the virtual fact does not
yet support windows.

Thanks!
The Pull Request Bot

Diff follows:

diff --git a/spec/unit/virtual_spec.rb b/spec/unit/virtual_spec.rb
index 995c814..b6e1414 100644
--- a/spec/unit/virtual_spec.rb
+++ b/spec/unit/virtual_spec.rb
@@ -226,11 +226,13 @@ describe "is_virtual fact" do
     end
 
     it "should be false on vmware_server" do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
         Facter.fact(:virtual).stubs(:value).returns("vmware_server")
         Facter.fact(:is_virtual).value.should == "false"
     end
 
     it "should be false on openvz host nodes" do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
         Facter.fact(:virtual).stubs(:value).returns("openvzhn")
         Facter.fact(:is_virtual).value.should == "false"
     end

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.