Please review pull request #58: (#9529) makes filter tabs accessible via keyboard opened by (djsauble2)

Description:

Adds an href tag to the link in each filter tab. This was
necessary because some browsers (e.g. Chrome) will not allow
a user to tab to a link if it does not have an href attribute.

  • Opened: Wed Nov 16 19:29:39 UTC 2011
  • Based on: puppetlabs:master (4d2c7b72772acb2f6f7e878796a83b3986aaeb2a)
  • Requested merge: djsauble2:9529_make_filter_tabs_accessible (39bb62ee964a63e50247de6ed6fb48ae99358f9b)

Diff follows:

diff --git a/app/views/pages/home.html.haml b/app/views/pages/home.html.haml
index d0acb4e..b736235 100644
--- a/app/views/pages/home.html.haml
+++ b/app/views/pages/home.html.haml
@@ -11,7 +11,7 @@
     %ul#home-tabs.tabbed
       - tab_statuses.each do |tab_status|
         %li(id="#{tab_status}-tab")
-          %a= tab_status.humanize
+          %a{:href ="" "#"}= tab_status.humanize
     - tab_statuses.each do |tab_status|
       %div.panel(id=tab_status)
         = render 'nodes/nodes',

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to