Please review pull request #119: Better handling of both new and old git checkouts. opened by (daniel-pittman)

Description:

This has flapped some, because we try to do too many clever things with remote
execution. Now, it should work robustly in all cases.

Signed-off-by: Daniel Pittman [email protected]

  • Opened: Sat Jan 21 18:53:04 UTC 2012
  • Based on: puppetlabs:master (e1bb15fc5120cb6c172bb5736baf5fbd785b8539)
  • Requested merge: daniel-pittman:faster-rerun-through-checkout-reuse (3a7284a9f217a613cfd62d5d3135079122450eac)

Diff follows:

diff --git a/setup/git/01_TestSetup.rb b/setup/git/01_TestSetup.rb
index f617c6e..7132eb2 100755
--- a/setup/git/01_TestSetup.rb
+++ b/setup/git/01_TestSetup.rb
@@ -35,7 +35,7 @@ def install_from_git(host, package, repo, revision)
 
   step "Clone #{repo} if needed"
   on host, "test -d #{SourcePath} || mkdir #{SourcePath}"
-  on host, "cd #{SourcePath} && test -d #{package} || cd #{SourcePath} && git clone #{repo} #{package}"
+  on host, "test -d #{target} || git clone #{repo} #{target}"
 
   step "Update #{package} and check out revision #{revision}"
   commands = ["cd #{target}",

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to