[Puppet-dev] (puppetlabs/puppet) (#12412) Don't assume root user exists

[wearetherobots]

Please review pull request #487: (#12412) Don't assume root user exists opened by (joshcooper)

Description:

Previously, the test was verifying that puppet didn't create the
root user, assuming it already existed on the host. But that's not
the case on Windows.

This commit just changes the test to use Host['user'], which always
refers to the user that we ssh'ed to the host as, and therefore,
always exists.

• Opened: Fri Feb 10 20:11:43 UTC 2012
• Based on: puppetlabs:2.7.x (21808b769173e2eb772a4ca41456fcfd81dbed1e)
• Requested merge: joshcooper:ticket/2.7.x/12412-root-user (a1957172a82e33feaa8bd5f9445a63284eb3d240)

Diff follows:

diff --git a/acceptance/tests/ticket_4110_puppet_apply_should_not_create_a_user_that_already_exists.rb b/acceptance/tests/ticket_4110_puppet_apply_should_not_create_a_user_that_already_exists.rb
index 1478573..1d7db23 100644
--- a/acceptance/tests/ticket_4110_puppet_apply_should_not_create_a_user_that_already_exists.rb
+++ b/acceptance/tests/ticket_4110_puppet_apply_should_not_create_a_user_that_already_exists.rb
@@ -1,7 +1,8 @@
 test_name "#4110: puppet apply should not create a user that already exists"
 
 agents.each do |host|
-  apply_manifest_on(host, "user { 'root': ensure => 'present' }") do
-     assert_no_match(/created/, stdout, "we tried to create root on #{host}" )
+  user = host['user']
+  apply_manifest_on(host, "user { '#{user}': ensure => 'present' }") do
+    assert_no_match(/created/, stdout, "we tried to create #{user} on #{host}")
   end
 end

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.