Please review pull request #507: Ticket/2.7.x/fix module spec for windows opened by (mmrobins)
Description:
Windows has a bigger list of reserved characters that can't be used in
directory names than Linux does, so a spec failed that tried to create
an invalid module dir actually created an invalid Windows dir.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#naming_conventions
The following reserved characters:
< (less than)
> (greater than)
: (colon)
" (double quote)
/ (forward slash)
\ (backslash)
| (vertical bar or pipe)
? (question mark)
* (asterisk)
The main point of the failing spec was to show the restrictions on module
directory names, which is /^[-\w]+$/, so I'm just going to use an '=' in the
spec since Windows doesn't reserve that.
- Opened: Wed Feb 15 22:15:22 UTC 2012
- Based on: puppetlabs:2.7.x (4d27b8b48da5af01fc315cc5a4bcedddc1fb7244)
- Requested merge: mmrobins:ticket/2.7.x/fix_module_spec_for_windows (e323bcec334f8abe7d24d1d395d37032fd3bfe81)
Diff follows:
diff --git a/spec/unit/node/environment_spec.rb b/spec/unit/node/environment_spec.rb
index 4adc5a6..6002cdb 100755
--- a/spec/unit/node/environment_spec.rb
+++ b/spec/unit/node/environment_spec.rb
@@ -314,7 +314,7 @@
FileUtils.mkdir_p(File.join(@first, 'foo2'))
FileUtils.mkdir_p(File.join(@first, 'foo-bar'))
FileUtils.mkdir_p(File.join(@first, 'foo_bar'))
- FileUtils.mkdir_p(File.join(@first, 'foo*bar'))
+ FileUtils.mkdir_p(File.join(@first, 'foo=bar'))
FileUtils.mkdir_p(File.join(@first, 'foo bar'))
env.modules.collect{|mod| mod.name}.sort.should == %w{foo foo-bar foo2 foo_bar}
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
