Please review pull request #217: (#14397) Use win32console v1.3.2 now, with pipe fixes opened by (kbarber)
Description:
Previously win32console was throwing errors in the acceptances tests due to a
bug in the code which was causing any redirected output to throw an exception:
https://github.com/luislavena/win32console/issues/14
This issue has now been solved, and subsequently win32console version 1.3.2 is
now safe to use.
- Opened: Mon May 14 20:52:18 UTC 2012
- Based on: puppetlabs:master (ab9bf37c2c879ae2264ba8552bdb421d49e1e65f)
- Requested merge: kbarber:ticket/master/14397-win32console_v1.3.2 (2ff30a1ad3df0bffe9299d36cf8cd4c3ec960c87)
Diff follows:
diff --git a/setup/git/00_EnvSetup.rb b/setup/git/00_EnvSetup.rb index e24963f..f6b4c08 100644 --- a/setup/git/00_EnvSetup.rb +++ b/setup/git/00_EnvSetup.rb @@ -1,7 +1,7 @@ test_name "Setup environment" WINDOWS_GEMS = [ - 'sys-admin', 'win32console -v1.3.0', 'win32-dir', 'win32-eventlog', + 'sys-admin', 'win32console -v1.3.2', 'win32-dir', 'win32-eventlog', 'win32-process', 'win32-service', 'win32-taskscheduler' ]
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
