Please review pull request #782: (#3669) Disable SRV record use by default. opened by (daniel-pittman)

Description:

This is a nice feature to have, but it is not widely used. It also triggers
some odd bugs in some common (embedded device) DNS recursive resolvers, which
simply ignore the question and lead to a long timeout waiting for the response
to come back.

Rather than ship this opt-out, it is safer to ship opt-in, and to allow people
to turn on the facility when they have configured it on their network.

Signed-off-by: Daniel Pittman [email protected]

  • Opened: Tue May 15 19:02:57 UTC 2012
  • Based on: puppetlabs:master (54da295f637ef75bcbc864b6740d6ae79c0901c1)
  • Requested merge: daniel-pittman:bug/master/3669-disable-srv-by-default (ac1b9d55a95f27a54ff924081d68687792dbd194)

Diff follows:

diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb
index fd05be4..d867cb0 100644
--- a/lib/puppet/defaults.rb
+++ b/lib/puppet/defaults.rb
@@ -966,7 +966,7 @@ module Puppet
       :desc => "The server to which the puppet agent should connect"
     },
     :use_srv_records => {
-      :default    => true,
+      :default    => false,
       :type       => :boolean,
       :desc       => "Whether the server will search for SRV records in DNS for the current domain.",
     },

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to