Just as a heads up--there have been some minor changes to that code in puppet over the last few months. (Particularly, some special handling of the case where the "~" character appears in the user's PATH.) I am not sure if these changes are relevant to facter (because I don't think Facter is doing as much manipulation of environment variables prior to spawning processes as puppet is), but it would be worth a quick once-over before this gets merged in, if it is decided that this is the way to go.
The pull req looks good to me, though, overall. On Fri, May 18, 2012 at 4:07 AM, Ken Barber <[email protected]> wrote: > Yeah - I think it was based on your advice KW. Stephen is awesome when > it comes to this kind of stuff. > > On Fri, May 18, 2012 at 11:29 AM, Krzysztof Wilczynski > <[email protected]> wrote: > > Hi, > > > > > > On Friday, May 18, 2012 10:30:18 AM UTC+1, Ken Barber wrote: > >> > >> Did you see the re-implementation of 'which' that Stephen Schulte is > >> working on here? > >> > >> https://github.com/puppetlabs/facter/pull/189 > > > > > > Nice one Ken! Stephen's implementation looks really nice! Definitely, a > +1 > > :) > > > > KW > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Puppet Developers" group. > > To view this discussion on the web visit > > https://groups.google.com/d/msg/puppet-dev/-/Mf-THp84e3YJ. > > > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]. > > For more options, visit this group at > > http://groups.google.com/group/puppet-dev?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
