Thanks for working on this, swfan. If you are going to continue working on this it would really help a lot if you could fork the project on github, make a branch for your changes, and then do a pull request from your branch to the facter 2.x branch (since this is a new feature and not a bug fix). That fits our updated contributor guidelines and also helps us to comment on submissions more easily.
Thanks, Andrew Parker On Jul 30, 2012, at 7:37 PM, swfan wrote: > just tried facter under a system wpar (for sun folks, equiv of sun zones)... > it fails. it cannot detect swap size/free as 'swap -l' does not work under > wpar's, nor does lsps -a. for that matter, 'swap -l' exists in aix >= 5.2, > so aix 5.1 fails here as well (its old, however we still have a few). > working on a patch for memory.rb to resolve the wpar/aix 5.1 swap detection > problem, or at least bypass it for now.. also, 'oslevel -s' does not work > under aix 5.1. > > also adjusting the virtual patches as they should be able to detect if facter > is under a wpar (system only, app wpar makes no sense to bother with). > > On Monday, July 9, 2012 3:46:18 PM UTC-4, swfan wrote: > created a ticket for this and attached the files. > > On Monday, July 2, 2012 4:30:54 PM UTC-4, Andy Parker wrote: > Thanks for the patches. Could you either submit a ticket on redmine > (https://projects.puppetlabs.com/projects/facter) and attach the patches or > fork facter on github and submit a pull request. That'll help us keep track > of this and make it a lot less likely that it'll just fall through the cracks. > > Thanks, > Andrew Parker > > On Jun 28, 2012, at 10:03 AM, swfan wrote: > >> Greetings folks >> Had not seen this in the facter 1.6.X branch, and I did not see it in the >> 2.x branch either (may have missed it). Posted this to the puppet-users >> group, did not realize it was probably the wrong group. >> >> Here are some patches to get some basic powervm (AIX client os only for now) >> detection to work: works so far for vscsi vios clients, and npiv enabled >> clients. >> I probably could come up with a shorter way to handle the npiv detection or >> others may have a nicer way as well. Tested on powervm 2.1 and 2.2, has >> worked with aix 5.3-7.1 vm's, does not require root privs. >> > > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/puppet-dev/-/totoQJwWQGwJ. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
