Brice -
On the held over issues, we didn't get a chance to discuss some of the ones from the prior week. All the *'s were quick updates, based on my scanning of those open PRs. <inline /> On Fri, Jun 6, 2014 at 12:31 AM, Brice Figureau < [email protected]> wrote: > Hi, > > On Wed, 2014-06-04 at 14:12 -0700, Ethan Brown wrote: > > > > > 2638 (PUP-2520): implements 'manual' environment directories > > - JoshP to contact contributor on PR > > - commits should reference PUP-2520 instead of 2520 > > My bad, I should have read the contributing doc before submitting. I'll > amend the commits. > > > - dubious value, and other higher priority work on environments > > ongoing > > I can't help thinking I fell in a trap. Why open a ticket, asking for a > contribution on the mailing list, if nobody thinks it's a good idea. I > spent a bit of time contributing this code I could have spent on other > things :( > > > - will consider pulling into a future sprint, but no time presently, > > most > > likely landing in Puppet 4 > > [snip] > > > 2704: (PUP-2569) (maint) Return last serial from SSL inventory > > - Andy to log a ticket, continue discussion on ticket, e.g. revoke > > all certificates for a specified name > > > > - PR needs to be updated with issue # in commit, revoke all > > certificates with a given name, preserve existing API > > I'm not sure I'll get it. To my knowledge the PR as the issue # in the > commit, a correct title, does its job and does preserve the existing > API. > Can someone enlighten me about the problem? > > In some cases, since it was a quick pass, some errant comments from the previous week were held over, which is the case here. For this one in particular, a completely new PR was opened that fixed most of the problems with the old one. However, we didn't get a chance to fully discuss during the triage this week, so it will be addressed in the next triage. FWIW, an updated version of the PR was pushed up on Wednesday AM. > > - Kylo to update pull request > > * formerly 2501, still open as of 6/4 > > Apologies for any confusion this caused. I should have segregated the issues from last week that we weren't able to address this past Wednesday. -- -- Ethan Brown [email protected] Software Engineer *Join us at PuppetConf 2014 <http://www.puppetconf.com/>, September 20-24 in San Francisco* *Register by June 5th to take advantage of the Early Adopter discount <http://links.puppetlabs.com/puppetconf-early-adopter> **—**save $349!* -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CALCHMcQ82oWsg6DePin5XLumctOgX8W%3DN5A2E_ngrRy0RgZ9JA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
