Note - we've removed the candidates for merging field because we have a dedicated team for pull requests again, and won't be pulling pull request issues into our normal sprints.
New: Puppet: 2870 (PUP-19708) Make the puppet agent retry failed requests. - Issue in commit message references projects.puppetlabs.com ticket, actual issue is https://tickets.puppetlabs.com/browse/PUP-2526 - There are a lot of cases where HTTP retries aren't meaningful (catalog retrieval, report submission) - As a general solution this is overkill, but we can retry things like file resource retrieval. - Needs better scoping of the issue being fixed 2869 Allow Upstart jobs on Amazon Linux - No ticket filed - This change requires adding a custom operatingsystemrelease fact for Amazon Linux, which makes it nonfunctional by default - The operatingsystemrelease fact implementation is backwards incompatible and no PR has been filed on Facter to make this work without patching - Mark issue as failed review and assign to contributor as fixup 2866 PUP-1244 puppet4 - Switches the yum provider to use RPM version comparison instead of semantic version comparison - This might be breaking but is more correct and has been requested since Puppet 0.24, document as a breaking change in Puppet 4 - Commit messages need to be fixed up, Andy to handle 2859 (PUP-1471) Puppet Agent windows services accidentally comes of out Paused state - This removes a warning about a bug that may no longer be relevant - Waiting on feedback from contributor, Josh to investigate Facter 721: (FACT-612) Add structured uptime fact - Retarget and fix up of Facter/712 - Initial pass looks good. - Adrien to look at 731: Display facts for aliases in *BSD - It looks like the code was written by a different contributor from the GitHub submitter, we need to work out the status of CLAs for the pull request - Code could use some refactoring, cleanup, and tests, but we can work with the contributor on that - Needs a JIRA issue Held over Facter 720: (FACT-617) Facter README.md should express semver - Looks alright. There are some comments about it but the puppet doc is the exact same wording. This change will get them in sync. - Will pull in for merge. 719: Ensure only major and minor versions are returned for CentOS 7. - No jira issue - Commit message needs - No tests - Need CLA signed - Need a better explanation of why this change is needed. Why isn't the release version just the release version? - Will to handle Hiera: 205: (HI-279) Hiera README.md should express semver - Same as Facter/720 198: Add YAML output format to CLI - Consensus is that the feature addition is good - Adrien to do any fix ups and get it merged 193: The hierarchy should dynamically grow if an interpolated variable contains an Array type of value - The request is reasonable within the user's context. Rather than adding yet more choices into hiera itself, we'd like to see this fixed by making the hierarchy mechanism plug able. - Adrien to comment and close 188: Allow for return of complex values across hiera - This will end up changing the behavior of some current queries. - Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no - Adrien provided a great example of the unexpected consequences it could have. - Back in the contributor's court for them to figure out if there is another design. Puppet: 2831: (CPR-42) file conflict upgrading from 2.7.26 to 3.6.2 - Needs to reference a PUP ticket 2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories - Already in discussion on puppet-dev 2779: (PUP-2802) add slot support for packages in portage.rb - Adrien needs to take it an review it for correctness/more intensive review - Commits need to be updated to contributing guidelines 2770: Allow version and held states of a package to specified as separate properties - Pull in for more intensive analysis - Commits need to be updated to contributing guidelines - Backwards compat problems because of the new parameters. - Adrien to summarize discussion 2614: (PUP-2452) Refresh support for Package type - Looks reasonable. - There is a question from the contributor about if there needs to be something changed to use this. - The answer to the question is, "yes, having a use of this is ideal". - Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does. - Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify. - This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality. - Adrien to write up the concerns in the PR and start a thread on puppet-dev to come to a decision about how to better control refresh events. 2709 (PUP-2701): Add PMT build metadata.json tests - Joshua Partlow to verify these on a few platforms before merging - Found some failures on centos6; will update prs and then ask if Kurt can continue -- Adrien Thebo | Puppet Labs -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CALVJ9S%2B2Vctno0oLO2dzZOwQj9dOxYUAC_wjx%2BEfnhPaGm5Fsg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
