Unfortunately it looks like there actually isn't a spec test for the ports provider right now - https://github.com/puppetlabs/puppet/tree/master/spec/unit/provider/package
If you feel like learning rspec and contributing tests for the provider, that would be awesome. Otherwise I think that this is going to be a sufficiently obvious change that we don't need to worry about it. -- Branan Riley Software Engineer, Puppet On Fri, May 5, 2017 at 9:21 AM Michael Smith <[email protected]> wrote: > You can run rspec. The standard way to do that for Ruby projects is to run > `bundle install`, then `bundle exec rspec spec`. You can also rely on the > CI systems on pull requests to check your code, but you'll get faster > feedback running locally. > > On Fri, May 5, 2017 at 2:29 AM <[email protected]> wrote: > >> Thanks! Is there a test suite I can run the tree through to make sure my >> patch is fine before i submit the PR? First change to the puppet code base >> itself... >> >> Richard >> >> On Thursday, May 4, 2017 at 4:23:54 PM UTC-7, Branan Purvine-Riley wrote: >> >>> I think it would be fine to put up the PR as-is, since FreeBSD 9 is EOL. >>> >>> Thanks for contributing, >>> Branan Riley >>> >> Software Engineer, Puppet >>> >>> On Thu, May 4, 2017 at 4:12 PM <[email protected]> wrote: >>> >> Hello, >>>> >>>> Today I think I found a bug in the ports provider for FreeBSD: >>>> puppet/lib/puppet/provider/package/ports.rb:7: >>>> >>>> :portinfo => "/usr/sbin/pkg_info" >>>> >>>> The pkg_info command has been replaced with 'pkg info' as of freebsd >>>> 10.0 : >>>> https://wiki.freebsd.org/PkgPrimer >>>> >>>> I've made a simple patch for the issue in ports.rb and freebsd.rb, >>>> which appears to fix the problem, but would likely break older releases >>>> than 10.0 which use the older pkg_info command. Can I submit a PR as is or >>>> do I need to account for older releases? 10.3 is the current oldest >>>> supported freebsd release. >>>> >>>> Thanks! >>>> Richard >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Puppet Developers" group. >>>> >>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>> >>> >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/puppet-dev/1c21454b-7e7e-42a5-b165-429a2ed34237%40googlegroups.com >>>> <https://groups.google.com/d/msgid/puppet-dev/1c21454b-7e7e-42a5-b165-429a2ed34237%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/puppet-dev/3c0b674f-eeca-4711-9958-d323a875c7c1%40googlegroups.com >> <https://groups.google.com/d/msgid/puppet-dev/3c0b674f-eeca-4711-9958-d323a875c7c1%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-dev/CABy1mMK0TdLoKGCSMn3djchYDxX4Jk-HA%2BbXxbxvgjQaHHe6dw%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-dev/CABy1mMK0TdLoKGCSMn3djchYDxX4Jk-HA%2BbXxbxvgjQaHHe6dw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CADWDnrmiyJT7_QFREAP3sxZeKLVJK0gTOXLrgB0TM19nTdTdng%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
