On Tuesday, August 28, 2018 at 6:50:48 PM UTC+3, Branan Purvine-Riley wrote:
> Hi Jon, > > In Puppet 6 we're going to start requiring that the names of > classes/defines match the name that's implied by their file path[1]. We > added that deprecation warning in 5.5.6[2] as part of a push to get > upcoming Puppet 6 changes printing warnings whenever possible. > > [1] https://tickets.puppetlabs.com/browse/PUP-1434 and > https://tickets.puppetlabs.com/browse/PUP-4242 > [2] https://tickets.puppetlabs.com/browse/PUP-8894 > Since 5.5.6 our puppetserver has been issuing warnings of this kind: Puppet Unacceptable location. The name 'bash' is unacceptable in file '/usr/local/etc/puppet/modules.common/bash/manifests/init.pp' The init.pp file contains only this: class bash { package { "shells/bash": ensure => installed, } } I am at a loss as to how I'm supposed to refactor this to make the warning go away. We do need an init.pp, and I know that for style points we should split this into a base class and a ::install class, but I refuse to believe that this is *required* for something as simple as the above. I am also not finding the documentation particularly helpful in this simple use-case. It does look like it's complaining about absolutely every class we have defined, no matter if we use only init.pp or properly-defined directory/file hierarchy and -naming for the classes, defines, etc. Can someone help me nudge my neurons in a way that I understand what is expected of me? /Eirik -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/1a76f507-f1a6-4115-be51-1c504fd84ed4%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
