also, for example, when you add a new vnet in a zone,
it was displaying a warning all vnets/zones for pending changes. as I don't have enough granularity currently (a global version info in /etc/network/interfaces.d/sdn, or we should have some kind of versioning info by vnet in /etc/network/interfaces.d/sdn) ----- Mail original ----- De: "aderumier" <[email protected]> À: "Thomas Lamprecht" <[email protected]> Cc: "Proxmox VE development discussion" <[email protected]> Envoyé: Vendredi 25 Septembre 2020 10:35:02 Objet: Re: [pve-devel] [PATCH v8 pve-network 09/25] api2: increase version on apply/reload only >>but how do you detect pending changes now? Well, the feature was mainly to detect pending change after reload. if a reload don't have applied correctly on a node, or if a node was down. I don't known if we want to display to user "pending config" changes, not yet applied ? Befor this commit, It's displaying warning after any config change, and it's difficult to known if a problem occur after the reload. ----- Mail original ----- De: "Thomas Lamprecht" <[email protected]> À: "Proxmox VE development discussion" <[email protected]>, "aderumier" <[email protected]> Envoyé: Vendredi 25 Septembre 2020 09:15:44 Objet: Re: [pve-devel] [PATCH v8 pve-network 09/25] api2: increase version on apply/reload only On 24.09.20 10:40, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier <[email protected]> > --- > PVE/API2/Network/SDN.pm | 3 +++ > PVE/API2/Network/SDN/Controllers.pm | 6 ------ > PVE/API2/Network/SDN/Subnets.pm | 3 --- > PVE/API2/Network/SDN/Vnets.pm | 3 --- > PVE/API2/Network/SDN/Zones.pm | 6 ------ > 5 files changed, 3 insertions(+), 18 deletions(-) > but how do you detect pending changes now? _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
