On 9/30/20 12:54 PM, Tim Marx wrote: [...]
diff --git a/lib/utils/promox_colors.dart b/lib/utils/promox_colors.dart new file mode 100644 index 0000000..f45ef3d --- /dev/null +++ b/lib/utils/promox_colors.dart @@ -0,0 +1,10 @@ +import 'package:flutter/material.dart'; + +class ProxmoxColors { + static final Color orange = Color(0xFFE57000); + static final Color black = Color(0xFF000000); + static final Color supportLightOrange = Color(0xFFFF9100); + static final Color supportGrey = Color(0xFFABBABA); + static final Color supportBlue = Color(0xFF00617F); + static final Color supportDarkGrey = Color(0xFF464D4D); +}With the exception of supportBlue (why support?) none of these colors are used why should we add them if they aren't used anywhere?
Having all company CI (corporate identity) colors readily available helps to avoid choosing some random color if a CI color would be appropriate as well as having to look them up manually. The colors are taken from the Brand Guidelines [0] and besides black and orange, which are the main colors, they are categorized as "supporting" colors. I wanted to have that distinction in some way. More colors are used in the welcome screen to have changing background colors.
Black is definitely not a color we need to define.
With the idea of having all company colors collected in one place, I would make the argument, that black should be part of it. If defined as Color(0xFF000000) or as Colors.black might be another discussion. [0] https://www.proxmox.com/en/news/media-kit _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
