Hi, Thank you for contributing to PVE!
Could you explain what the patch fixes and why it works (would also be great to have that information in the commit-message)? I checked our bugzilla and the community forum, but could not find any recent issue regarding gluster and containers (I probably overlooked it). AFAICT the patch disables running syncfs(2) on the gluster fuse-mount used for containers. Does the syncfs call fail? What error do you get? The syncfs call is there to ensure that the backup is consistent as far as possible - so I would not disable it without rationale. On another note - we would need a signed CLA from you, in order to be able to include your code in our codebase - see [0]. Best Regards, stoiko [0] https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright On Thu, 12 Nov 2020 19:48:38 +0100 Thomas Legay <tho...@lgy.fr> wrote: > Thomas Legay (1): > Allow LXC snapshot backup with glusterfs mount point > > src/PVE/LXC.pm | 1 + > 1 file changed, 1 insertion(+) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
