back in 2018, commit 1accc6da659d8a02dcf1c2a636749e6f48fb9c2d
"Inotify : write network config : use modern syntax for options"
changed pve-common's /etc/network/interfaces writer to prefer options
with '-' over those with '_'.

having the installer write the old variant makes any modification of the
vmbr0 interface via the API also change these three lines to the new
variant - so let's do it right from the start.

Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com>
---
https://forum.proxmox.com/threads/wrong-elaboration-of-etc-network-interface-by-proxmox-gui.91271/

 proxinstall | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxinstall b/proxinstall
index d18ad6c..98cee66 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1627,9 +1627,9 @@ sub extract_data {
                "\nauto vmbr0\niface vmbr0 $ntype static\n" .
                "\taddress $cidr\n" .
                "\tgateway $gateway\n" .
-               "\tbridge_ports $ethdev\n" .
-               "\tbridge_stp off\n" .
-               "\tbridge_fd 0\n";
+               "\tbridge-ports $ethdev\n" .
+               "\tbridge-stp off\n" .
+               "\tbridge-fd 0\n";
        } else {
            $ifaces .= "auto $ethdev\n" .
                "iface $ethdev $ntype static\n" .
-- 
2.30.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to