Series looks good to me, except for a small nit.

Reviewed-by: Fabian Ebner <f.eb...@proxmox.com>

Am 28.09.21 um 15:07 schrieb Lorenz Stechauner:
changes to v1:
* adjusted preallocation api description
* moved sub preallocation_cmd_option above `# Storage implementation`
* updated PreallocationSelector to work with `default`
* reworked placement of Prealloc.Selector in Base.js

pve-storage
Lorenz Stechauner (1):
   fix #3580: plugins: make preallocation mode selectable for qcow2 and
     raw images

  PVE/Storage/BTRFSPlugin.pm     |  1 +
  PVE/Storage/CIFSPlugin.pm      |  1 +
  PVE/Storage/DirPlugin.pm       |  1 +
  PVE/Storage/GlusterfsPlugin.pm |  4 ++-
  PVE/Storage/NFSPlugin.pm       |  1 +
  PVE/Storage/Plugin.pm          | 48 +++++++++++++++++++++++++++++++++-
  6 files changed, 54 insertions(+), 2 deletions(-)


pve-manager:
Lorenz Stechauner (2):
   ui: add PreallocationSelector
   fix 3850: ui: storage: using PreallocationSelector for file based
     storage types

  www/manager6/Makefile                      |  1 +
  www/manager6/controller/StorageEdit.js     |  6 ++++++
  www/manager6/form/PreallocationSelector.js | 11 +++++++++++
  www/manager6/storage/Base.js               | 18 ++++++++++++++++++
  www/manager6/storage/NFSEdit.js            |  2 +-
  5 files changed, 37 insertions(+), 1 deletion(-)
  create mode 100644 www/manager6/form/PreallocationSelector.js



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to