On 14.02.22 12:02, Fabian Ebner wrote: > Otherwise, the header might already get written by a coroutine and > registering further streams will fail after that. > > Also adds a missing g_list_free call for the other GList that's used.
just as note: it's cleaner this way, especially if we'd reuse `create_archive` in the future, but currently this doesn't changes much, as it was the program exited immediately afterwards, so returning all resources back to the OS, anyway. > > Reported in the community forum: > https://forum.proxmox.com/threads/104744/ > > Reproducer script (increase beyond 30 if the issue isn't triggered yet): >> #!/usr/bin/perl >> >> my $dir = "./vma-create-bug"; >> mkdir $dir; >> >> my $archive_path = "$dir/vzdump-qemu-104-2202_02_02-00_00_00.vma"; >> unlink $archive_path; >> >> my $cmd = "vma create $archive_path -v"; >> for (my $i = 0; $i < 30; $i++) { >> system("truncate -s 1M $dir/drive-virtio$i.img"); >> $cmd .= " drive-virtio$i=$dir/drive-virtio$i.img"; >> } >> system($cmd); > > Signed-off-by: Fabian Ebner <[email protected]> > --- > > A late addition to v2. Also later unrelated, so I applied it now already, avoiding the need to release 6.2 to repos already for the forum user to test this. > > ...VE-Backup-add-vma-backup-format-code.patch | 24 +++++++++++++++---- > 1 file changed, 19 insertions(+), 5 deletions(-) > > applied, thanks! _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
