If an OSD is removed during the wrong conditions, it could lead to blocked IO or worst case data loss.
Check against global flags that limit the capabilities of Ceph to heal itself (norebalance, norecover, noout) and if there are degraded objects. Unfortunately, the 'safe-to-destroy' API endpoint will not help here as it only works as long as the OSD is still running. By the time the destroy button is enabled, the OSD needs to be stopped. Signed-off-by: Aaron Lauterer <a.laute...@proxmox.com> --- After the short discussion on the previous version [0] and the hints to ok-to-stop & safe-to-destroy I kept the original approach with the reason given in the commit message. But now the checks are run before opening the window and showing a loading screen. [0] https://lists.proxmox.com/pipermail/pve-devel/2022-February/051597.html www/manager6/ceph/OSD.js | 66 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index e126f8d0..27f56760 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -178,6 +178,20 @@ Ext.define('PVE.CephRemoveOsd', { labelWidth: 130, fieldLabel: gettext('Cleanup Disks'), }, + { + xtype: 'displayfield', + name: 'osd-flag-hint', + userCls: 'pmx-hint', + value: gettext('Global flags limiting the self healing of Ceph are enabled.'), + hidden: true, + }, + { + xtype: 'displayfield', + name: 'degraded-objects-hint', + userCls: 'pmx-hint', + value: gettext('Objects are degraded. Consider waiting until the cluster is healthy.'), + hidden: true, + }, ], initComponent: function() { let me = this; @@ -198,6 +212,13 @@ Ext.define('PVE.CephRemoveOsd', { }); me.callParent(); + + if (me.warnings.flags) { + me.down('field[name=osd-flag-hint]').setHidden(false); + } + if (me.warnings.degraded) { + me.down('field[name=degraded-objects-hint]').setHidden(false); + } }, }); @@ -434,12 +455,55 @@ Ext.define('PVE.node.CephOsdTree', { }).show(); }, - destroy_osd: function() { + destroy_osd: async function() { let me = this; let vm = this.getViewModel(); + + let warnings = { + flags: false, + degraded: false, + }; + + let flagsPromise = Proxmox.Async.api2({ + url: `/cluster/ceph/flags`, + method: 'GET', + }); + + let statusPromise = Proxmox.Async.api2({ + url: `/cluster/ceph/status`, + method: 'GET', + }); + + me.getView().mask(gettext('Please wait...')); + + try { + let result = await Promise.all([flagsPromise, statusPromise]); + + let flagsData = result[0].result.data; + let statusData = result[1].result.data; + + let flags = Array.from( + flagsData.filter(v => v.value), + v => v.name, + ).filter(v => ['norebalance', 'norecover', 'noout'].includes(v)); + + if (flags.length) { + warnings.flags = true; + } + if (Object.keys(statusData.pgmap).includes('degraded_objects')) { + warnings.degraded = true; + } + } catch (error) { + Ext.Msg.alert(gettext('Error'), error.htmlStatus); + me.getView().unmask(); + return; + } + + me.getView().unmask(); Ext.create('PVE.CephRemoveOsd', { nodename: vm.get('osdhost'), osdid: vm.get('osdid'), + warnings: warnings, taskDone: () => { me.reload(); }, }).show(); }, -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
