[pve-devel] [PATCH qemu-server 1/1] api: create/modify: add content type checks

[Fabian Ebner]

Signed-off-by: Fabian Ebner <f.eb...@proxmox.com>
---
 PVE/API2/Qemu.pm | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index cb6973f1..1dd0cf28 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -104,7 +104,14 @@ my $check_storage_access = sub {
            raise_param_exc({ storage => "storage '$storeid' does not support 
vm images"})
                if !$scfg->{content}->{images};
        } else {
-           PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, 
$vmid, $volid);
+           PVE::Storage::check_volume_access(
+               $rpcenv,
+               $authuser,
+               $storecfg,
+               $vmid,
+               $volid,
+               'images',
+           );
        }
     });
 
@@ -230,7 +237,14 @@ my $create_disks = sub {
            delete $disk->{format}; # no longer needed
            $res->{$ds} = PVE::QemuServer::print_drive($disk);
        } else {
-           PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, 
$vmid, $volid);
+           PVE::Storage::check_volume_access(
+               $rpcenv,
+               $authuser,
+               $storecfg,
+               $vmid,
+               $volid,
+               'images',
+           );
 
            PVE::Storage::activate_volumes($storecfg, [ $volid ]) if $storeid;
 
@@ -645,7 +659,14 @@ __PACKAGE__->register_method({
                die "pipe requires cli environment\n" if $rpcenv->{type} ne 
'cli';
                $archive = { type => 'pipe' };
            } else {
-               PVE::Storage::check_volume_access($rpcenv, $authuser, 
$storecfg, $vmid, $archive);
+               PVE::Storage::check_volume_access(
+                   $rpcenv,
+                   $authuser,
+                   $storecfg,
+                   $vmid,
+                   $archive,
+                   'backup',
+               );
 
                $archive = $parse_restore_archive->($storecfg, $archive);
            }
-- 
2.30.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel